[PATCH] fbdev: atyfb: Remove unused fb_list

[PATCH] fbdev: atyfb: Remove unused fb_list

[Geert Uytterhoeven]

With clang and W=1:

    drivers/video/fbdev/aty/atyfb_base.c:2327:24: warning: variable 'fb_list' set but not used [-Wunused-but-set-global]
	2327 | static struct fb_info *fb_list = NULL;

Indeed, the last user of fb_list was removed in 2004, while the actual
linked list was removed in 2002.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202603300931.osMYxYZ7-lkp@intel.com/
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/video/fbdev/aty/atyfb_base.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
index d5e107730a4d75dd..9fc5af09f86c4df2 100644
--- a/drivers/video/fbdev/aty/atyfb_base.c
+++ b/drivers/video/fbdev/aty/atyfb_base.c
@@ -2324,8 +2324,6 @@ static void aty_calc_mem_refresh(struct atyfb_par *par, int xclk)
  * Initialisation
  */
 
-static struct fb_info *fb_list = NULL;
-
 #if defined(__i386__) && defined(CONFIG_FB_ATY_GENERIC_LCD)
 static int atyfb_get_timings_from_lcd(struct atyfb_par *par,
 				      struct fb_var_screeninfo *var)
@@ -2758,8 +2756,6 @@ static int aty_init(struct fb_info *info)
 #endif
 	}
 
-	fb_list = info;
-
 	PRINTKI("fb%d: %s frame buffer device on %s\n",
 		info->node, info->fix.id, par->bus_type == ISA ? "ISA" : "PCI");
 	return 0;
-- 
2.43.0

Claude review: fbdev: atyfb: Remove unused fb_list

[Claude Code Review Bot]

Overall Series Review

Subject: fbdev: atyfb: Remove unused fb_list
Author: Geert Uytterhoeven <geert@linux-m68k.org>
Patches: 1
Reviewed: 2026-03-31T17:25:36.507096

---

This is a single, trivial cleanup patch that removes a dead variable (`fb_list`) from the ATY framebuffer driver. The change is correct and well-motivated — the variable is set but never read, as confirmed by a clang W=1 warning. The commit message provides good historical context (last user removed in 2004, linked list removed in 2002).

**Verdict: Looks good. No issues found.**

---
Generated by Claude Code Patch Reviewer

Claude review: fbdev: atyfb: Remove unused fb_list

[Claude Code Review Bot]

Patch Review

**Status: Clean**

The patch removes two things:

1. The static variable declaration:
```c
-static struct fb_info *fb_list = NULL;
```

2. The assignment in `aty_init()`:
```c
-	fb_list = info;
```

Both removals are straightforward dead code elimination. The variable was only ever assigned to, never read from, which is exactly what the clang warning reports. No other references to `fb_list` exist in this file (the diff removes all of them), so there's no risk of breaking anything.

The commit message properly credits the kernel test robot report and includes the `Closes:` tag linking to the build warning.

**Reviewed-by worthy.** No concerns.

---
Generated by Claude Code Patch Reviewer