From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH v2] drm/bridge: dw-hdmi-qp: compute audio CTS from N when not in TMDS table
Date: Mon, 25 May 2026 22:06:43 +1000 [thread overview]
Message-ID: <review-overall-81944af1-c9e3-4a45-ad42-3426dcab0777@kwiboo.se> (raw)
In-Reply-To: <81944af1-c9e3-4a45-ad42-3426dcab0777@kwiboo.se>
Overall Series Review
Subject: Re: [PATCH v2] drm/bridge: dw-hdmi-qp: compute audio CTS from N when not in TMDS table
Author: Jonas Karlman <jonas@kwiboo.se>
Patches: 3
Reviewed: 2026-05-25T22:06:43.782096
---
This is a single, well-motivated patch that fixes an audio mute issue on HDMI sinks when using TMDS character rates not covered by the static CTS lookup table (`common_tmds_cts_table[]`). The commit message is excellent — clear problem statement, root cause analysis, the fix rationale, precedent in the legacy driver, and comprehensive test results across multiple sinks and rates.
The code change is small, correct, and follows an established pattern from the legacy `dw-hdmi.c` driver. The formula `CTS = (TMDS * N) / (128 * Fs)` is straight from the HDMI specification.
**Verdict: This patch looks good and is ready to apply.** One minor observation below, but nothing blocking.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 9:10 [PATCH v2] drm/bridge: dw-hdmi-qp: compute audio CTS from N when not in TMDS table Simon Wright
2026-05-20 9:38 ` Jonas Karlman
2026-05-21 7:44 ` Simon Wright
2026-05-25 12:06 ` Claude Code Review Bot [this message]
2026-05-25 12:06 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-81944af1-c9e3-4a45-ad42-3426dcab0777@kwiboo.se \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox