Claude review: Re: [PATCH v3] staging: fbtft: replace empty macro args with identity converter

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Re: [PATCH v3] staging: fbtft: replace empty macro args with identity converter
Author: Andy Shevchenko <andy.shevchenko@gmail.com>
Patches: 5
Reviewed: 2026-04-13T18:50:47.485308

---

This mbox contains two patches addressing the same issue in `drivers/staging/fbtft/fbtft-bus.c`: the `define_fbtft_write_reg` macro is invoked with an empty 4th argument for the no-conversion cases. Patch 1 is a broken v1 that removes the argument entirely, while Patch 2 (labeled v3) is the corrected approach that introduces an identity macro. Only Patch 2 should be considered for merging.

The series has formatting/process issues: Patch 1 is a standalone `[PATCH]` (not a cover letter) that contains a full diff of a broken approach, and Patch 2 is `[PATCH v3]` sent as a reply. This is confusing — v3 should have been sent as its own top-level thread, with a note that it supersedes the prior versions.

Patch 2 is functionally correct but its commit message makes an inaccurate claim about undefined behavior.

---
Generated by Claude Code Patch Reviewer