From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: misc: fastrpc: fix DMA address corruption due to find_vma misuse
Date: Sat, 16 May 2026 09:24:08 +1000 [thread overview]
Message-ID: <review-overall-SYBPR01MB78819393A1F4FA658B2AB076AF042@SYBPR01MB7881.ausprd01.prod.outlook.com> (raw)
In-Reply-To: <SYBPR01MB78819393A1F4FA658B2AB076AF042@SYBPR01MB7881.ausprd01.prod.outlook.com>
Overall Series Review
Subject: misc: fastrpc: fix DMA address corruption due to find_vma misuse
Author: Junrui Luo <moonafterrain@outlook.com>
Patches: 1
Reviewed: 2026-05-16T09:24:08.007858
---
This is a single-patch fix for a real bug in the fastrpc driver. The analysis is correct: `find_vma()` returns the first VMA with `vma->vm_end > addr`, which means if the address falls in a gap *before* that VMA, the subsequent arithmetic `(ptr & PAGE_MASK) - vma->vm_start` will underflow (since `ptr` could be well below `vma->vm_start`), corrupting the DMA address passed to the DSP. Replacing with `vma_lookup()` is the standard and correct fix — it returns NULL when the address is not contained within any VMA, so the offset calculation is only performed when the address genuinely belongs to the found VMA.
The patch is minimal, correct, and appropriate for stable backport.
**Verdict: Looks good.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-15 23:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 9:16 [PATCH] misc: fastrpc: fix DMA address corruption due to find_vma misuse Junrui Luo
2026-05-15 23:24 ` Claude review: " Claude Code Review Bot
2026-05-15 23:24 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-SYBPR01MB78819393A1F4FA658B2AB076AF042@SYBPR01MB7881.ausprd01.prod.outlook.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox