public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: fix error handling bugs in amdgpu_userq_create()
Date: Sun, 12 Apr 2026 09:10:36 +1000	[thread overview]
Message-ID: <review-overall-SYBPR01MB7881A5714C08FAF6A974EDA1AF262@SYBPR01MB7881.ausprd01.prod.outlook.com> (raw)
In-Reply-To: <SYBPR01MB7881A5714C08FAF6A974EDA1AF262@SYBPR01MB7881.ausprd01.prod.outlook.com>

Overall Series Review

Subject: drm/amdgpu: fix error handling bugs in amdgpu_userq_create()
Author: Junrui Luo <moonafterrain@outlook.com>
Patches: 1
Reviewed: 2026-04-12T09:10:36.963748

---

This is a 2-patch series from Junrui Luo fixing error handling bugs in `amdgpu_userq_create()` related to the XArray-based queue tracking introduced by commit f18719ef4bb7. The series claims to fix a use-after-free and a resource leak in error paths.

**Critical issue: The mbox file only contains the cover letter (patch 0/2).** The actual patches (1/2 and 2/2) were not captured in the filtered mbox, so this review is based on the cover letter descriptions and analysis of the current source tree.

**The patches could not be applied**, and analyzing the current drm-next code at `drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c`, **both issues described in the cover letter appear to already be fixed** in the current tree. The error paths in `amdgpu_userq_create()` on drm-next already properly handle cleanup of both the XArray entries and the MQD/fence resources. This strongly suggests these fixes (or equivalent ones) have already been merged.

---

---
Generated by Claude Code Patch Reviewer

      reply	other threads:[~2026-04-11 23:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-11  9:24 [PATCH 0/2] drm/amdgpu: fix error handling bugs in amdgpu_userq_create() Junrui Luo
2026-04-11 23:10 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-SYBPR01MB7881A5714C08FAF6A974EDA1AF262@SYBPR01MB7881.ausprd01.prod.outlook.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox