From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] cgroup/dmem: return -ENOMEM on failed pool preallocation
Date: Sat, 16 May 2026 15:56:05 +1000 [thread overview]
Message-ID: <review-overall-c6b89ff53b603350fe53b0d47f3399ed@kernel.org> (raw)
In-Reply-To: <c6b89ff53b603350fe53b0d47f3399ed@kernel.org>
Overall Series Review
Subject: Re: [PATCH] cgroup/dmem: return -ENOMEM on failed pool preallocation
Author: Tejun Heo <tj@kernel.org>
Patches: 4
Reviewed: 2026-05-16T15:56:05.178465
---
This is a single-patch fix for a real infinite loop bug in `kernel/cgroup/dmem.c`. The analysis in the commit message is correct: when `get_cg_pool_locked()` returns `ERR_PTR(-ENOMEM)`, the code clears `pool` to NULL, then attempts a fallback `kzalloc_obj()`. If that fallback allocation also fails, `pool` remains NULL and the `while (!pool)` loop spins forever, burning CPU without ever being able to make progress. The fix is minimal, correct, and well-placed.
**Verdict: Good patch, should be accepted.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 5:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 1:31 [PATCH] cgroup/dmem: return -ENOMEM on failed pool preallocation Guopeng Zhang
2026-05-11 1:46 ` Tejun Heo
2026-05-16 5:56 ` Claude review: " Claude Code Review Bot
2026-05-16 5:56 ` Claude Code Review Bot [this message]
2026-05-11 13:03 ` Michal Koutný
[not found] ` <1778555389652035.138.seg@mailgw.kylinos.cn>
2026-05-12 7:04 ` Guopeng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-c6b89ff53b603350fe53b0d47f3399ed@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox