From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Replace old pointer to new idr
Date: Sat, 16 May 2026 12:36:42 +1000 [thread overview]
Message-ID: <review-overall-tencent_C267296443AAA4567771176886DFF364A305@qq.com> (raw)
In-Reply-To: <tencent_C267296443AAA4567771176886DFF364A305@qq.com>
Overall Series Review
Subject: drm: Replace old pointer to new idr
Author: Edward Adam Davis <eadavis@qq.com>
Patches: 1
Reviewed: 2026-05-16T12:36:42.355520
---
This is a single-patch fix for a syzbot-reported bug where `drm_prime_destroy_file_private` triggers `WARN_ON(!RB_EMPTY_ROOT(&prime_fpriv->dmabufs))` on file close. The patch correctly identifies that commit 5e28b7b94408 placed the `idr_replace` call in the error path instead of the success path, but the fix itself introduces a **new, more serious bug** by removing the necessary `idr_alloc` failure check. The drm-next tree already has a clean version of this function without `idr_replace`, suggesting this fix may already be superseded or targeting a different branch.
**Verdict: NACK in current form** — the core idea (moving `idr_replace` to the success path) is right, but the removal of the `ret < 0` check after `idr_alloc` is incorrect and introduces state corruption.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-16 2:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 19:56 [syzbot] [dri?] WARNING in drm_prime_destroy_file_private (3) syzbot
2026-05-13 4:30 ` [PATCH] drm: Replace old pointer to new idr Edward Adam Davis
2026-05-16 2:36 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-tencent_C267296443AAA4567771176886DFF364A305@qq.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox