public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/disp/dpu: consider SSPP line width during mode valid
Date: Tue, 31 Mar 2026 17:55:49 +1000	[thread overview]
Message-ID: <review-patch1-20260328-msm-next-v1-1-12ac4e27c670@oss.qualcomm.com> (raw)
In-Reply-To: <20260328-msm-next-v1-1-12ac4e27c670@oss.qualcomm.com>

Patch Review

**The fix is incomplete for the non-3d_merge path.**

The patch only constrains the final `drm_mode_validate_size()` call, changing:
```c
2 * dpu_kms->catalog->caps->max_mixer_width
```
to:
```c
2 * min_t(u32, max_mixer_width, max_linewidth)
```

But earlier in the same function (around line 1598-1600), there is:
```c
if (!dpu_kms->catalog->caps->has_3d_merge &&
    mode->hdisplay > dpu_kms->catalog->caps->max_mixer_width)
    return MODE_BAD_HVALUE;
```

For targets *without* `has_3d_merge` where `max_linewidth < max_mixer_width` (e.g., sm6150 has no `has_3d_merge`, max_mixer_width=2560, max_linewidth=2160), this early check still allows modes up to 2560 wide, even though the SSPP can only handle 2160. Those modes would pass `mode_valid` and then presumably fail at `atomic_check`.

**This early check should also be clamped by `max_linewidth`**, something like:
```c
if (!dpu_kms->catalog->caps->has_3d_merge &&
    mode->hdisplay > min_t(u32, dpu_kms->catalog->caps->max_mixer_width,
                           dpu_kms->catalog->caps->max_linewidth))
    return MODE_BAD_HVALUE;
```

**Minor: the commit message could be more specific.** The message says "few targets have lesser SSPP line width" — it would be helpful to name the affected targets (sm6150, sm6125, sm6115, qcm2290, sm6375, etc.) and perhaps add a `Fixes:` tag if this addresses a regression or user-reported issue, or at least a `Cc: stable` if backport is desired.

**The code itself is otherwise correct:** `min_t(u32, ...)` is the right macro, the `max_width` variable is properly typed, and the comment update accurately describes the new logic.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-31  7:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-28 17:15 [PATCH] drm/msm/disp/dpu: consider SSPP line width during mode valid Vishnu Saini
2026-03-29  0:24 ` Dmitry Baryshkov
2026-03-30 18:30   ` Vishnu Saini
2026-03-30 18:39     ` Dmitry Baryshkov
2026-03-30 18:57       ` Vishnu Saini
2026-03-30 19:38         ` Dmitry Baryshkov
2026-03-31  7:55 ` Claude Code Review Bot [this message]
2026-03-31  7:55 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260328-msm-next-v1-1-12ac4e27c670@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox