Claude review: dma-fence: Move signalling tracepoint to before ops detach

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Analysis:** The tracepoint `trace_dma_fence_signaled(fence)` uses the `dma_fence` event class which dereferences `fence->ops` to call `get_driver_name()` and `get_timeline_name()` (see `include/trace/events/dma_fence.h` lines 24-25):

```c
__string(driver, fence->ops->get_driver_name(fence))
__string(timeline, fence->ops->get_timeline_name(fence))
```

The commit being fixed (541c8f2468b9) added logic that sets `fence->ops` to NULL when the ops has no `release` or `wait` callback:

```c
ops = rcu_dereference_protected(fence->ops, true);
if (!ops->release && !ops->wait)
    RCU_INIT_POINTER(fence->ops, NULL);
```

With the tracepoint placed *after* this code (as in the current tree at line 380), enabling the tracepoint will cause a NULL dereference for any fence whose ops lack both `release` and `wait`.

Moving the tracepoint before the ops detach logic is the correct fix. The tracepoint still runs after the `DMA_FENCE_FLAG_SIGNALED_BIT` is set (which is the logical signal point), so it still accurately records the signal event.

**Minor observation:** The tracepoint is now also emitted before `fence->timestamp` is assigned. This means the tracepoint fires slightly earlier in the sequence — before timestamp assignment and before callbacks run — but the tracepoint doesn't record the timestamp so this is not a functional concern.

**Nit on commit message format:** The `Fixes:` tag should conventionally come before the `Signed-off-by`. This is a minor style point and not a blocking issue.

**Verdict:** Reviewed-by worthy. The fix is minimal, correct, and addresses a real crash.

---
Generated by Claude Code Patch Reviewer