From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-fence: Move signalling tracepoint to before ops detach
Date: Tue, 31 Mar 2026 17:14:43 +1000 [thread overview]
Message-ID: <review-overall-20260330133623.17704-1-tvrtko.ursulin@igalia.com> (raw)
In-Reply-To: <20260330133623.17704-1-tvrtko.ursulin@igalia.com>
Overall Series Review
Subject: dma-fence: Move signalling tracepoint to before ops detach
Author: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Patches: 2
Reviewed: 2026-03-31T17:14:43.479696
---
This is a single-patch bugfix for a NULL pointer dereference introduced by commit 541c8f2468b9 ("dma-buf: detach fence ops on signal v3"). The fix is correct, straightforward, and clearly necessary. The tracepoint class at line 24 of `dma_fence.h` accesses `fence->ops->get_driver_name(fence)` and `fence->ops->get_timeline_name(fence)`, which will crash if `fence->ops` has been set to NULL by the ops detach logic added in the Fixes commit.
The patch is **good to merge** as-is.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-31 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 13:36 [PATCH] dma-fence: Move signalling tracepoint to before ops detach Tvrtko Ursulin
2026-03-30 14:24 ` Philipp Stanner
2026-03-31 7:14 ` Claude review: " Claude Code Review Bot
2026-03-31 7:14 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260330133623.17704-1-tvrtko.ursulin@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox