From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/v3d: Use devm_reset_control_get_optional_exclusive()
Date: Wed, 01 Apr 2026 07:45:10 +1000 [thread overview]
Message-ID: <review-patch1-20260331-v3d-power-management-v9-1-f52ff87bfd36@igalia.com> (raw)
In-Reply-To: <20260331-v3d-power-management-v9-1-f52ff87bfd36@igalia.com>
Patch Review
**Status: Looks good.**
Clean, straightforward conversion from `devm_reset_control_get_exclusive()` to `devm_reset_control_get_optional_exclusive()`. The old code had an ad-hoc optional pattern (check for `-EPROBE_DEFER`, set to NULL otherwise); the new code uses the proper API that returns NULL when the reset is absent and only returns errors for real failures.
The switch to `dev_err_probe()` is a nice touch — it handles `-EPROBE_DEFER` logging automatically.
No issues. Already has R-b from Melissa, Philipp, and Florian.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 21:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 12:35 [PATCH v9 0/3] Power Management for Raspberry Pi V3D GPU Maíra Canal
2026-03-31 12:35 ` [PATCH v9 1/3] drm/v3d: Use devm_reset_control_get_optional_exclusive() Maíra Canal
2026-03-31 21:45 ` Claude Code Review Bot [this message]
2026-03-31 12:35 ` [PATCH v9 2/3] drm/v3d: Allocate all resources before enabling the clock Maíra Canal
2026-03-31 21:45 ` Claude review: " Claude Code Review Bot
2026-03-31 12:35 ` [PATCH v9 3/3] drm/v3d: Introduce Runtime Power Management Maíra Canal
2026-03-31 15:33 ` Florian Fainelli
2026-03-31 21:45 ` Claude review: " Claude Code Review Bot
2026-03-31 21:45 ` Claude review: Power Management for Raspberry Pi V3D GPU Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-28 18:52 [PATCH v8 0/3] " Maíra Canal
2026-03-28 18:52 ` [PATCH v8 1/3] drm/v3d: Use devm_reset_control_get_optional_exclusive() Maíra Canal
2026-03-31 7:53 ` Claude review: " Claude Code Review Bot
2026-03-12 21:34 [PATCH v7 0/5] Power Management for Raspberry Pi V3D GPU Maíra Canal
2026-03-12 21:34 ` [PATCH v7 3/5] drm/v3d: Use devm_reset_control_get_optional_exclusive() Maíra Canal
2026-03-13 3:47 ` Claude review: " Claude Code Review Bot
2026-02-13 18:52 [PATCH v5 0/7] Power Management for Raspberry Pi V3D GPU Maíra Canal
2026-02-13 18:52 ` [PATCH v5 5/7] drm/v3d: Use devm_reset_control_get_optional_exclusive() Maíra Canal
2026-02-13 21:21 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260331-v3d-power-management-v9-1-f52ff87bfd36@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox