public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/imx: Fix three kernel-doc warnings in dcss-scaler.c
Date: Sun, 12 Apr 2026 14:25:41 +1000	[thread overview]
Message-ID: <review-patch1-20260406180013.2442096-1-yiconghui@gmail.com> (raw)
In-Reply-To: <20260406180013.2442096-1-yiconghui@gmail.com>

Patch Review

**Status: Looks good**

The patch adds three missing `@param` entries to kernel-doc comments:

1. `@phase0_identity` in `dcss_scaler_gaussian_filter()` (line 169) — description "whether to override phase 0 coefficients with identity filter" accurately matches the usage at line 227:
   ```c
   /* override phase 0 with identity filter if specified */
   if (phase0_identity)
       for (i = 0; i < PSC_NUM_TAPS; i++)
           coef[0][i] = i == (PSC_NUM_TAPS >> 1) ?
                       (1 << PSC_COEFF_PRECISION) : 0;
   ```

2. `@phase0_identity` in `dcss_scaler_filter_design()` (line 266) — same description, parameter is passed through to `dcss_scaler_gaussian_filter()`. Accurate.

3. `@nn_interpolation` in `dcss_scaler_filter_design()` (line 268) — description "whether to use nearest neighbor instead of gaussian filter" accurately matches the usage at line 283:
   ```c
   if (nn_interpolation)
       dcss_scaler_nearest_neighbor_filter(use_5_taps, coef);
   else
       dcss_scaler_gaussian_filter(fc_q, use_5_taps, phase0_identity, coef);
   ```

**Minor nit (non-blocking):** In `dcss_scaler_filter_design()`, the `@coef` and `@nn_interpolation` doc entries are ordered as `@coef` then `@nn_interpolation`, but the function signature has `coef` before `nn_interpolation` too — so the ordering is correct. Good.

**On the Fixes tag:** The `Fixes:` tag pointing to the original commit `9021c317b770` ("drm/imx: Add initial support for DCSS on iMX8MQ") is technically correct since that's where the undocumented parameters were introduced, though using `Fixes:` for a kernel-doc-only change is debatable — this isn't fixing a functional bug. It's common practice either way, so this is just a style observation.

**Verdict:** Patch is correct and ready to apply. The descriptions are accurate, the parameter order in the doc comments matches the function signatures, and the three W=1 warnings will be resolved.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-04-12  4:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-06 18:00 [PATCH] drm/imx: Fix three kernel-doc warnings in dcss-scaler.c Yicong Hui
2026-04-12  4:25 ` Claude review: " Claude Code Review Bot
2026-04-12  4:25 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260406180013.2442096-1-yiconghui@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox