From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: uapi: Use SPDX in DRM core uAPI headers
Date: Sun, 12 Apr 2026 13:38:53 +1000 [thread overview]
Message-ID: <review-patch1-20260407104951.1781047-1-laurent.pinchart+renesas@ideasonboard.com> (raw)
In-Reply-To: <20260407104951.1781047-1-laurent.pinchart+renesas@ideasonboard.com>
Patch Review
**Documentation change (`Documentation/gpu/drm-uapi.rst`):**
The added paragraph is well-placed, directly after the discussion of uAPI review requirements and before the render nodes section:
```
+The DRM subsystem has however no concern with independent closed-source
+userspace implementations. To officialize that position, the DRM uAPI headers
+are covered by the MIT license.
```
Minor nit: "officialize" is not a standard English word — "formalize" would be more conventional. That said, the meaning is perfectly clear, and this has already been reviewed by multiple maintainers including Simona who participated in the original discussion, so this is not worth blocking on.
**Header changes (`drm.h`, `drm_fourcc.h`, `drm_mode.h`, `drm_sarea.h`):**
All four headers follow the same clean pattern:
1. Add `/* SPDX-License-Identifier: MIT */` as the very first line
2. Remove the verbose MIT license text
3. Preserve copyright notices and author attributions
The changes are mechanically correct. The SPDX tag is placed on line 1 as required by kernel convention, copyright lines are retained, and no functional code is touched. The slight variations in the removed license text (e.g., `drm.h` names "VA LINUX SYSTEMS", `drm_sarea.h` names "TUNGSTEN GRAPHICS", `drm_mode.h` uses "AUTHORS OR COPYRIGHT HOLDERS") are all correctly identified as MIT license variants and appropriately replaced by the single `MIT` SPDX identifier.
One observation: `drm.h` has a slightly unusual structure after the patch — it ends up with two separate comment blocks (one for the header description/author and one for the copyright notices). This is a pre-existing structure and the patch handles it correctly by inserting the SPDX tag before the first block and removing the license text from the second.
**No concerns.** The patch is clean, well-reviewed, and correct. Recommend merging.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 3:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 10:49 [PATCH v3] drm: uapi: Use SPDX in DRM core uAPI headers Laurent Pinchart
2026-04-12 3:38 ` Claude Code Review Bot [this message]
2026-04-12 3:38 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260407104951.1781047-1-laurent.pinchart+renesas@ideasonboard.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox