From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/radeon: replace nested min calls with min3
Date: Sun, 12 Apr 2026 13:20:25 +1000 [thread overview]
Message-ID: <review-patch1-20260407181407.1052586-2-thorsten.blum@linux.dev> (raw)
In-Reply-To: <20260407181407.1052586-2-thorsten.blum@linux.dev>
Patch Review
**Status:** Reviewed-by worthy
The patch modifies two functions that are structurally identical across two files:
- `dce8_available_bandwidth()` in `drivers/gpu/drm/radeon/cik.c`
- `dce6_available_bandwidth()` in `drivers/gpu/drm/radeon/si.c`
In both cases, the change is:
```c
- return min(dram_bandwidth, min(data_return_bandwidth, dmif_req_bandwidth));
+ return min3(dram_bandwidth, data_return_bandwidth, dmif_req_bandwidth);
```
**Correctness:** The kernel's `min3()` macro (from `linux/minmax.h`) is equivalent to `min(a, min(b, c))`, so this is a no-op in terms of behavior. All three variables are `u32`, so there are no type-promotion concerns.
**Commit message:** Accurate and concise. Correctly names both affected functions.
**No issues found.** This is a clean readability improvement with no risk.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 3:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 18:14 [PATCH] drm/radeon: replace nested min calls with min3 Thorsten Blum
2026-04-12 3:20 ` Claude Code Review Bot [this message]
2026-04-12 3:20 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260407181407.1052586-2-thorsten.blum@linux.dev \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox