From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/colorop: Add DRM_COLOROP_FIXED_MATRIX
Date: Sun, 12 Apr 2026 13:07:22 +1000 [thread overview]
Message-ID: <review-patch1-20260408051514.608781-2-chaitanya.kumar.borah@intel.com> (raw)
In-Reply-To: <20260408051514.608781-2-chaitanya.kumar.borah@intel.com>
Patch Review
**Overall**: Clean UAPI addition. The new colorop type and its initialization follow existing patterns well.
**Issue (minor)**: Kernel-doc tag mismatch. The kdoc comment says `@DRM_COLOROP_FM_YCBCR2020_NC_FULL_RGB` but the actual enum value is `DRM_COLOROP_FM_YCBCR2020_FULL_RGB_NC`:
```c
/**
* @DRM_COLOROP_FM_YCBCR2020_NC_FULL_RGB: // <-- wrong
...
*/
DRM_COLOROP_FM_YCBCR2020_FULL_RGB_NC, // <-- actual name
```
This will generate a kernel-doc warning. The `@` tag must exactly match the symbol name.
**Observation**: The `supported_fm` parameter is `u64` which supports up to 64 fixed matrix types, but `DRM_COLOROP_FM_COUNT` is currently 6. The overflow check `(supported_fm & -BIT(DRM_COLOROP_FM_COUNT)) != 0` is correct.
**Question for discussion**: `DRM_COLOROP_FM_YCBCR_LIMITED_FULL` represents range correction, not a color space conversion matrix. Mixing these two concepts in one enum is workable but may be confusing to userspace. Consider whether this warrants a separate colorop type (though the current approach is pragmatic for hardware that implements both as fixed-function blocks).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 3:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 5:15 [PATCH v2 00/13] drm/i915/color: Enable SDR plane color pipeline Chaitanya Kumar Borah
2026-04-08 5:15 ` [PATCH v2 01/13] drm/colorop: Add DRM_COLOROP_FIXED_MATRIX Chaitanya Kumar Borah
2026-04-12 3:07 ` Claude Code Review Bot [this message]
2026-04-08 5:15 ` [PATCH v2 02/13] drm/i915/color: Add CSC on SDR plane color pipeline Chaitanya Kumar Borah
2026-04-12 3:07 ` Claude review: " Claude Code Review Bot
2026-04-08 5:15 ` [PATCH v2 03/13] drm/i915/color: Program fixed-function CSC on SDR planes Chaitanya Kumar Borah
2026-04-12 3:07 ` Claude review: " Claude Code Review Bot
2026-04-08 5:15 ` [PATCH v2 04/13] drm/i915/color: Add support for 1D LUT in " Chaitanya Kumar Borah
2026-04-12 3:07 ` Claude review: " Claude Code Review Bot
2026-04-08 5:15 ` [PATCH v2 05/13] drm/i915/color: Fix HDR pre-CSC LUT programming loop Chaitanya Kumar Borah
2026-04-12 3:07 ` Claude review: " Claude Code Review Bot
2026-04-08 5:15 ` [PATCH v2 06/13] drm/i915/color: Extract HDR pre-CSC LUT programming to helper function Chaitanya Kumar Borah
2026-04-12 3:07 ` Claude review: " Claude Code Review Bot
2026-04-08 5:15 ` [PATCH v2 07/13] drm/i915/color: Program Pre-CSC registers for SDR Chaitanya Kumar Borah
2026-04-12 3:07 ` Claude review: " Claude Code Review Bot
2026-04-08 5:15 ` [PATCH v2 08/13] drm/i915/color: Extract HDR post-CSC LUT programming to helper function Chaitanya Kumar Borah
2026-04-12 3:07 ` Claude review: " Claude Code Review Bot
2026-04-08 5:15 ` [PATCH v2 09/13] drm/i915/color: Program Plane Post CSC registers for SDR planes Chaitanya Kumar Borah
2026-04-12 3:07 ` Claude review: " Claude Code Review Bot
2026-04-08 5:15 ` [PATCH v2 10/13] drm/i915/color: Add color pipeline support " Chaitanya Kumar Borah
2026-04-12 3:07 ` Claude review: " Claude Code Review Bot
2026-04-08 5:15 ` [PATCH v2 11/13] drm/i915/color: Add YCbCr limited-to-full range color block support Chaitanya Kumar Borah
2026-04-12 3:07 ` Claude review: " Claude Code Review Bot
2026-04-08 5:15 ` [PATCH v2 12/13] drm/i915/color: Program plane YUV range correction colorop Chaitanya Kumar Borah
2026-04-12 3:07 ` Claude review: " Claude Code Review Bot
2026-04-08 5:15 ` [PATCH v2 13/13] drm/i915/color: Add YUV range correction to SDR plane pipeline Chaitanya Kumar Borah
2026-04-12 3:07 ` Claude review: " Claude Code Review Bot
2026-04-12 3:07 ` Claude review: drm/i915/color: Enable SDR plane color pipeline Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260408051514.608781-2-chaitanya.kumar.borah@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox