public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/color: Add YUV range correction to SDR plane pipeline
Date: Sun, 12 Apr 2026 13:07:25 +1000	[thread overview]
Message-ID: <review-patch13-20260408051514.608781-14-chaitanya.kumar.borah@intel.com> (raw)
In-Reply-To: <20260408051514.608781-14-chaitanya.kumar.borah@intel.com>

Patch Review

**Overall**: Simple one-liner adding `INTEL_PLANE_CB_YUV_RANGE_CORRECT` at the front of the SDR pipeline:
```c
static const enum intel_color_block sdr_plane_pipeline[] = {
    INTEL_PLANE_CB_YUV_RANGE_CORRECT,
    INTEL_PLANE_CB_PRE_CSC_LUT,
    INTEL_PLANE_CB_CSC_FF,
    INTEL_PLANE_CB_POST_CSC_LUT,
};
```

The ordering (range correction → pre-CSC LUT → CSC → post-CSC LUT) matches the hardware pipeline and is logically correct: limited-to-full range expansion must happen before the CSC that expects full-range input.

No issues.

---

**Summary of required fixes:**

1. **Must fix**: `glk_plane_color_ctl()` needs mutual exclusion between legacy and colorop-based CSC/range-correction paths. The colorop path should only apply when a color pipeline is active on the plane, and the legacy path should be skipped in that case. Without this, the series introduces a regression for existing YUV content on SDR planes and a corruption bug when both paths activate simultaneously.

2. **Should fix**: Replace `plane - 3` magic number with a derived value or named constant, and add a defensive WARN_ON.

3. **Should fix**: Kernel-doc `@DRM_COLOROP_FM_YCBCR2020_NC_FULL_RGB` → `@DRM_COLOROP_FM_YCBCR2020_FULL_RGB_NC`.

4. **Consider**: Move patch 5 (bug fix) to the beginning of the series and submit it independently for stable backport, separate from the feature patches.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-12  3:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08  5:15 [PATCH v2 00/13] drm/i915/color: Enable SDR plane color pipeline Chaitanya Kumar Borah
2026-04-08  5:15 ` [PATCH v2 01/13] drm/colorop: Add DRM_COLOROP_FIXED_MATRIX Chaitanya Kumar Borah
2026-04-12  3:07   ` Claude review: " Claude Code Review Bot
2026-04-08  5:15 ` [PATCH v2 02/13] drm/i915/color: Add CSC on SDR plane color pipeline Chaitanya Kumar Borah
2026-04-12  3:07   ` Claude review: " Claude Code Review Bot
2026-04-08  5:15 ` [PATCH v2 03/13] drm/i915/color: Program fixed-function CSC on SDR planes Chaitanya Kumar Borah
2026-04-12  3:07   ` Claude review: " Claude Code Review Bot
2026-04-08  5:15 ` [PATCH v2 04/13] drm/i915/color: Add support for 1D LUT in " Chaitanya Kumar Borah
2026-04-12  3:07   ` Claude review: " Claude Code Review Bot
2026-04-08  5:15 ` [PATCH v2 05/13] drm/i915/color: Fix HDR pre-CSC LUT programming loop Chaitanya Kumar Borah
2026-04-12  3:07   ` Claude review: " Claude Code Review Bot
2026-04-08  5:15 ` [PATCH v2 06/13] drm/i915/color: Extract HDR pre-CSC LUT programming to helper function Chaitanya Kumar Borah
2026-04-12  3:07   ` Claude review: " Claude Code Review Bot
2026-04-08  5:15 ` [PATCH v2 07/13] drm/i915/color: Program Pre-CSC registers for SDR Chaitanya Kumar Borah
2026-04-12  3:07   ` Claude review: " Claude Code Review Bot
2026-04-08  5:15 ` [PATCH v2 08/13] drm/i915/color: Extract HDR post-CSC LUT programming to helper function Chaitanya Kumar Borah
2026-04-12  3:07   ` Claude review: " Claude Code Review Bot
2026-04-08  5:15 ` [PATCH v2 09/13] drm/i915/color: Program Plane Post CSC registers for SDR planes Chaitanya Kumar Borah
2026-04-12  3:07   ` Claude review: " Claude Code Review Bot
2026-04-08  5:15 ` [PATCH v2 10/13] drm/i915/color: Add color pipeline support " Chaitanya Kumar Borah
2026-04-12  3:07   ` Claude review: " Claude Code Review Bot
2026-04-08  5:15 ` [PATCH v2 11/13] drm/i915/color: Add YCbCr limited-to-full range color block support Chaitanya Kumar Borah
2026-04-12  3:07   ` Claude review: " Claude Code Review Bot
2026-04-08  5:15 ` [PATCH v2 12/13] drm/i915/color: Program plane YUV range correction colorop Chaitanya Kumar Borah
2026-04-12  3:07   ` Claude review: " Claude Code Review Bot
2026-04-08  5:15 ` [PATCH v2 13/13] drm/i915/color: Add YUV range correction to SDR plane pipeline Chaitanya Kumar Borah
2026-04-12  3:07   ` Claude Code Review Bot [this message]
2026-04-12  3:07 ` Claude review: drm/i915/color: Enable SDR plane color pipeline Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch13-20260408051514.608781-14-chaitanya.kumar.borah@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox