From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/exynos/fimd: fix register offset type in fimd_trigger()
Date: Sun, 12 Apr 2026 13:00:10 +1000 [thread overview]
Message-ID: <review-patch1-20260408065055.1353444-1-wenst@chromium.org> (raw)
In-Reply-To: <20260408065055.1353444-1-wenst@chromium.org>
Patch Review
**Status: Clean, correct fix.**
The `ctx->regs` field is declared as `void __iomem *regs` (line 182 of `exynos_drm_fimd.c`). When `fimd_trigger()` computes a derived pointer from it:
```c
- void *timing_base = ctx->regs + driver_data->timing_base;
+ void __iomem *timing_base = ctx->regs + driver_data->timing_base;
```
the old code drops the `__iomem` address space annotation, which causes sparse to rightfully complain when `timing_base` is later passed to `readl()` and `writel()` (lines 1005 and 1007), which expect `__iomem`-qualified pointers.
Adding `__iomem` to the local variable type makes the types consistent throughout the function. This is a no-op change at the binary level (sparse annotations have no runtime effect) but improves static analysis coverage.
The `Fixes:` tag correctly points to commit `3854fab24e89` which introduced the `fimd_trigger()` function with the original type mismatch.
Reviewed-by worthy as-is.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-12 3:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 6:50 [PATCH] drm/exynos/fimd: fix register offset type in fimd_trigger() Chen-Yu Tsai
2026-04-12 3:00 ` Claude review: " Claude Code Review Bot
2026-04-12 3:00 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260408065055.1353444-1-wenst@chromium.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox