public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: Fix kernel-doc in panthor_sched.c so it's visible
Date: Sun, 12 Apr 2026 12:47:45 +1000	[thread overview]
Message-ID: <review-patch1-20260408091242.799074-1-steven.price@arm.com> (raw)
In-Reply-To: <20260408091242.799074-1-steven.price@arm.com>

Patch Review

**Typo bug -- `@synwait.sync64` should be `@syncwait.sync64`:**

The patch introduces a typo in one of the very fixes it's making:

```
-		/** @sync64: True if this is a 64-bit sync object. */
+		/** @synwait.sync64: True if this is a 64-bit sync object. */
```

This should be `@syncwait.sync64` (missing the 'c'). All other members of the same anonymous struct correctly use `@syncwait.*` (e.g. `@syncwait.gpu_va`, `@syncwait.ref`, `@syncwait.gt`, `@syncwait.obj`, `@syncwait.offset`, `@syncwait.kmap`). This typo means `sync64` would still not be properly visible in kernel-doc output, which defeats the purpose of the patch for this particular field.

**Fix for stale `@bo` tag name is good, but leaves a dangling cross-reference:**

The patch correctly renames the doc tag from `@bo` to `@syncwait.obj` to match the actual field name `obj`:

```
-		/** @bo: Buffer object holding the synchronization object. */
+		/** @syncwait.obj: Buffer object holding the synchronization object. */
```

However, the description of the next member still references `@bo`:

```
+		/** @syncwait.offset: Offset of the synchronization object inside @bo. */
```

Now that the tag has been corrected to `@syncwait.obj`, this `@bo` cross-reference is dangling. It should be updated to `@syncwait.obj` (or simply `@obj`) for consistency. This is a minor nit but worth fixing while you're in this code.

**Rest of the changes look correct.** The mechanical addition of parent struct prefixes (`@groups.`, `@pm.`, `@reset.`, `@iface.`, `@fence_ctx.`, `@profiling.`, `@fdinfo.`, `@call_info.`, `@ringbuf.`) all match the actual anonymous struct field names in the source tree. The `Fixes:` tag referencing the original commit that introduced the scheduler is appropriate.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-04-12  2:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08  9:12 [PATCH] drm/panthor: Fix kernel-doc in panthor_sched.c so it's visible Steven Price
2026-04-08  9:31 ` Boris Brezillon
2026-04-08 13:46 ` Liviu Dudau
2026-04-08 14:09 ` Steven Price
2026-04-12  2:47 ` Claude review: " Claude Code Review Bot
2026-04-12  2:47 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260408091242.799074-1-steven.price@arm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox