From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: MAINTAINERS: Add dedicated entry for fbcon
Date: Sun, 12 Apr 2026 11:31:38 +1000 [thread overview]
Message-ID: <review-patch1-20260409072711.12500-1-tzimmermann@suse.de> (raw)
In-Reply-To: <20260409072711.12500-1-tzimmermann@suse.de>
Patch Review
**Correctness of the entry format:** The entry follows standard MAINTAINERS format correctly -- `M:` for maintainers, `L:` for mailing lists, `S:` for status, `T:` for tree, `F:` for files. All fields are properly formatted.
**Maintainers (M:):** Lists Helge Deller and Thomas Zimmermann. Helge is already the maintainer of the FRAMEBUFFER LAYER entry, so his inclusion here is consistent. Thomas is a well-known DRM/fbdev contributor at SUSE.
**Mailing lists (L:):** Lists both `dri-devel@lists.freedesktop.org` and `linux-fbdev@vger.kernel.org`, which makes sense since fbcon straddles both DRM and fbdev.
**Tree (T:):** Points to `git https://gitlab.freedesktop.org/drm/misc/kernel.git`, matching the FRAMEBUFFER CORE entry. This is the drm-misc tree, which is appropriate since fbcon patches often come through the DRM tree.
**File coverage:** All 13 listed files/directories exist in the tree:
- `Documentation/fb/fbcon.rst` -- fbcon documentation
- `drivers/video/fbdev/core/bitblit.c`, `fb_logo.c`, `fbcon.c`, `fbcon.h`, `fbcon_ccw.c`, `fbcon_cw.c`, `fbcon_rotate.c`, `fbcon_rotate.h`, `fbcon_ud.c`, `softcursor.c`, `tileblit.c` -- all fbcon core files
- `include/linux/fbcon.h`, `include/linux/font.h` -- related headers
- `lib/fonts/` -- font library directory
**Overlap consideration:** The existing FRAMEBUFFER CORE entry uses `F: drivers/video/fbdev/core/` which is a wildcard covering all files in that directory, including the fbcon files now explicitly listed. Similarly, FRAMEBUFFER LAYER uses `F: drivers/video/` and `F: Documentation/fb/` which overlap. This is fine and intentional -- `get_maintainer.pl` handles overlapping entries by reporting all matching maintainers, and having a more specific entry ensures fbcon patches get routed to the right people. The explicit file listing (rather than a wildcard like `F: drivers/video/fbdev/core/fbcon*`) is more verbose but ensures files like `bitblit.c`, `softcursor.c`, and `tileblit.c` that don't start with `fbcon` are correctly captured.
**One minor observation:** `include/linux/font.h` and `lib/fonts/` are font-related rather than fbcon-specific, and are also used outside of fbcon (e.g., by DRM drivers for boot logos). Including them here is reasonable since fbcon is the primary consumer, but it's worth noting that patches to `lib/fonts/` will now also CC the fbcon maintainers, which seems appropriate.
**Verdict:** Looks good. No changes needed.
Reviewed-by for this patch would be appropriate.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-12 1:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 7:26 [PATCH v2] MAINTAINERS: Add dedicated entry for fbcon Thomas Zimmermann
2026-04-09 8:13 ` Helge Deller
2026-04-12 1:31 ` Claude review: " Claude Code Review Bot
2026-04-12 1:31 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260409072711.12500-1-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox