public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: fix htmldocs error for dma_buf_attach_revocable
Date: Sun, 12 Apr 2026 09:39:23 +1000	[thread overview]
Message-ID: <review-patch1-20260410123703.937822-1-sumit.semwal@linaro.org> (raw)
In-Reply-To: <20260410123703.937822-1-sumit.semwal@linaro.org>

Patch Review

**Status: Looks good (Reviewed-by worthy)**

The problem: In the kernel-doc comment for `dma_buf_invalidate_mappings()`, the text:

```c
 * accessed:
 *  1) Until dma_resv_wait_timeout() ...
```

is missing a blank comment line between the paragraph ending in `:` and the start of the numbered list. The RST parser doesn't recognize the numbered list without that separator.

The fix adds the required blank `*` line:

```c
 * accessed:
 *
 *  1) Until dma_resv_wait_timeout() ...
```

This is the standard kernel-doc convention — a blank `*` line is needed before a list block for proper RST rendering. I confirmed the current tree at `drivers/dma-buf/dma-buf.c:1355-1356` has exactly this missing blank line.

**Minor nit (non-blocking):** The subject says "for dma_buf_attach_revocable" but the comment being fixed is actually on `dma_buf_invalidate_mappings()`. The Fixes tag correctly points to the commit that introduced the problematic comment, but the subject could be slightly more precise as "fix htmldocs error for dma_buf_invalidate_mappings". This is cosmetic and not worth a respin.

No functional or correctness issues. The patch is trivially correct.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-11 23:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 12:37 [PATCH] dma-buf: fix htmldocs error for dma_buf_attach_revocable Sumit Semwal
2026-04-10 12:43 ` Christian König
2026-04-10 14:06   ` Sumit Semwal
2026-04-11 23:39 ` Claude Code Review Bot [this message]
2026-04-11 23:39 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260410123703.937822-1-sumit.semwal@linaro.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox