public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/nouveau: fix nvkm_device leak on aperture removal failure
Date: Sun, 12 Apr 2026 09:12:26 +1000	[thread overview]
Message-ID: <review-patch1-20260411062938.22925-1-devnexen@gmail.com> (raw)
In-Reply-To: <20260411062938.22925-1-devnexen@gmail.com>

Patch Review

**Correctness: Confirmed.**

The probe function allocates the nvkm device early:

```c
ret = nvkm_device_pci_new(pdev, nouveau_config, nouveau_debug, &device);
if (ret)
    return ret;
```

`nvkm_device_pci_new()` internally calls `pci_enable_device()` (at `nvkm/engine/device/pci.c:1662`), so on success we hold both the device allocation and a PCI enable reference.

The very next fallible call is:

```c
ret = aperture_remove_conflicting_pci_devices(pdev, driver_pci.name);
if (ret)
-       return ret;
+       goto fail_nvkm;
```

The old `return ret` skips cleanup entirely. The `fail_nvkm` label correctly runs:

```c
fail_nvkm:
    nvkm_device_del(&device);
    return ret;
```

And `nvkm_device_del` invokes `nvkm_device_pci_dtor()` which calls `pci_disable_device()` (`pci.c:1635`), properly balancing the enable taken during `nvkm_device_pci_new()`.

There is no double-free risk here: at this point in the probe sequence, no other resources (the second `pci_enable_device` at line 891, `nouveau_drm_device_new`, etc.) have been allocated yet, so jumping to `fail_nvkm` — which only tears down the nvkm device — is the correct label.

**Commit message:** Accurate. The description correctly identifies what leaks, why, and which commit introduced the problem.

**Tags:** `Fixes:` and `Cc: stable` are appropriate.

**No issues found.** This could take a:

Reviewed-by if you agree with the analysis.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-04-11 23:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-11  6:29 [PATCH] drm/nouveau: fix nvkm_device leak on aperture removal failure David Carlier
2026-04-11 23:12 ` Claude review: " Claude Code Review Bot
2026-04-11 23:12 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260411062938.22925-1-devnexen@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox