From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/nouveau: fix nvkm_device leak on aperture removal failure
Date: Sun, 12 Apr 2026 09:12:26 +1000 [thread overview]
Message-ID: <review-overall-20260411062938.22925-1-devnexen@gmail.com> (raw)
In-Reply-To: <20260411062938.22925-1-devnexen@gmail.com>
Overall Series Review
Subject: drm/nouveau: fix nvkm_device leak on aperture removal failure
Author: David Carlier <devnexen@gmail.com>
Patches: 1
Reviewed: 2026-04-12T09:12:26.635838
---
This is a single-patch series fixing a resource leak in `nouveau_drm_probe()`. The analysis and fix are correct. When `aperture_remove_conflicting_pci_devices()` fails, the code previously returned directly, leaking the `nvkm_device` allocated by `nvkm_device_pci_new()` and the `pci_enable_device()` reference it takes internally. The fix properly routes to the existing `fail_nvkm` error label.
The patch is minimal, targeted, and appropriate for stable backport.
**Verdict: Looks good.**
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-11 23:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 6:29 [PATCH] drm/nouveau: fix nvkm_device leak on aperture removal failure David Carlier
2026-04-11 23:12 ` Claude Code Review Bot [this message]
2026-04-11 23:12 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260411062938.22925-1-devnexen@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox