From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err()
Date: Thu, 23 Apr 2026 10:15:08 +1000 [thread overview]
Message-ID: <review-patch1-20260420064544.266478-1-suryasaimadhu369@gmail.com> (raw)
In-Reply-To: <20260420064544.266478-1-suryasaimadhu369@gmail.com>
Patch Review
**Status: Looks good**
The conversion is correct:
- `bridge->dev` is `struct drm_device *` (confirmed from `drm_bridge.h:1104`), which is the correct first argument for `drm_err()`.
- The `__func__` prefix was correctly removed — `drm_err()` already includes device identification in its output, so the function name is unnecessary (and the original `__func__` usage was unusual for this kind of error message anyway).
- After the patch, no `DRM_ERROR` calls remain in `mtk_hdmi.c`, so the conversion is complete for this file.
- The error message text is clear and adequate.
**Minor nit:** The error message string says `"DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n"` — while this is functionally fine and matches the flag name, a slightly more descriptive phrasing like `"The flag DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n"` (preserving the original's wording minus `__func__`) would be marginally clearer to someone reading logs. This is very minor and not worth blocking on.
**Verdict:** Patch is correct and complete. No issues.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-23 0:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 6:45 [PATCH v2] drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err() sai madhu
2026-04-23 0:15 ` Claude review: " Claude Code Review Bot
2026-04-23 0:15 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260420064544.266478-1-suryasaimadhu369@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox