public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: jdi-fhd-r63452: remove panel on DSI attach failure
Date: Thu, 23 Apr 2026 10:13:55 +1000	[thread overview]
Message-ID: <review-patch1-20260420065305.8781-1-mhun512@gmail.com> (raw)
In-Reply-To: <20260420065305.8781-1-mhun512@gmail.com>

Patch Review

**Correctness:** The fix is correct. Looking at the probe function:

```c
drm_panel_add(&ctx->panel);          // line 203

ret = mipi_dsi_attach(dsi);          // line 205
if (ret < 0) {
    dev_err(dev, "Failed to attach to DSI host: %d\n", ret);
    return ret;                      // BUG: panel left in global list
}
```

`devm_drm_panel_alloc()` registers a devm action for `drm_panel_put()` but does NOT handle `drm_panel_remove()` — the `drm_panel_add()`/`drm_panel_remove()` lifecycle is the driver's responsibility. The `.remove()` callback at line 214 calls `drm_panel_remove()`, but that path is never taken when probe fails. So the added `drm_panel_remove()` call is the correct fix.

**Commit message:** The commit message clearly explains the problem and solution. However:

- **Missing `Fixes:` tag.** This is a bugfix and should reference the commit that introduced the bug. This is important for stable-kernel backporting. The commit that introduced the driver (or that converted it to `devm_drm_panel_alloc` without adding error-path cleanup) should be cited.

**Style:** The patch is minimal and well-placed — exactly one line in the right location.

**Nit:** The blank line between "If mipi_dsi_attach() fails, the driver returns without calling" and "drm_panel_remove()" in the commit message body (lines 101-102 of the mbox) appears to be an unintentional line break splitting a sentence across paragraphs. It should read as a continuous paragraph.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-04-23  0:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20  6:52 [PATCH] drm/panel: jdi-fhd-r63452: remove panel on DSI attach failure Myeonghun Pak
2026-04-22 19:25 ` Dmitry Baryshkov
2026-04-23  0:13 ` Claude review: " Claude Code Review Bot
2026-04-23  0:13 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260420065305.8781-1-mhun512@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox