public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vkms: Clean up artifacts from old vblank timer
Date: Thu, 23 Apr 2026 09:36:04 +1000	[thread overview]
Message-ID: <review-patch1-20260420131831.242882-1-tzimmermann@suse.de> (raw)
In-Reply-To: <20260420131831.242882-1-tzimmermann@suse.de>

Patch Review

**Changes reviewed:**

1. **`vkms_drv.h`: Remove `#include <linux/hrtimer.h>`** — Correct. No struct members or function signatures in this header use `hrtimer_*` types after the conversion. The include is dead.

2. **`vkms_drv.h`: Remove kernel-doc for `vblank_hrtimer` and `period_ns`** — Correct. These fields were removed in `02e2681ffe1a` but their documentation was left behind. Removing orphaned kernel-doc entries is the right cleanup.

3. **`vkms_composer.c` line 597**: Comment update from `vkms_vblank_simulate()` to `vkms_crtc_handle_vblank_timeout()` — Correct. `vkms_crtc_handle_vblank_timeout` exists in `vkms_crtc.c:16` and is the current function name.

4. **`vkms_composer.c` line 639**: Comment update from "vblank hrtimer" to "vblank timer" — Correct.

**Issue — missed stale reference:**

There is a third "hrtimer" comment in `vkms_composer.c` at line 662 that was not updated:

```c
/*
 * The worker can fall behind the vblank hrtimer, make sure we catch up.
 */
```

This should be changed to "vblank timer" for consistency with the other comment fix in this same patch. Since the stated goal of the patch is to "fix comments referring to the original implementation," this seems like an oversight.

**Nit:** The `Fixes:` tag is arguably unnecessary here — this is a comment/include cleanup, not a functional fix. It won't cause backporting confusion since the referenced commit is recent, but `Fixes:` typically implies a behavioral/correctness issue that stable kernels should pick up. This is minor and a matter of project convention.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-22 23:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 13:18 [PATCH] drm/vkms: Clean up artifacts from old vblank timer Thomas Zimmermann
2026-04-22 23:36 ` Claude Code Review Bot [this message]
2026-04-22 23:36 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260420131831.242882-1-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox