public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Fix DYNAMIC_DEBUG_MODULE propagation to subdirectories
Date: Thu, 23 Apr 2026 08:49:03 +1000	[thread overview]
Message-ID: <review-patch1-20260420160425.3919114-1-sean@poorly.run> (raw)
In-Reply-To: <20260420160425.3919114-1-sean@poorly.run>

Patch Review

**Correctness: Good.** The two changes are:

```makefile
-CFLAGS-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)	+= -DDYNAMIC_DEBUG_MODULE
+ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)	+= -DDYNAMIC_DEBUG_MODULE
+subdir-ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)	+= -DDYNAMIC_DEBUG_MODULE
```

1. `CFLAGS-y` is not a kbuild-recognized variable — this was simply dead code. Changing to `ccflags-y` is the correct fix (per `Documentation/kbuild/makefiles.rst:321`).

2. Adding `subdir-ccflags-y` propagates the flag to all subdirectories under `drivers/gpu/drm/`, which is essential since DRM drivers live in subdirectories like `amd/`, `i915/`, `nouveau/`, etc. Without this, files calling `drm_dbg()` and friends in those subdirectories would still get implicit-declaration errors for `_dynamic_func_call_cls`.

**Minor observation:** Per the kbuild documentation (`makefiles.rst:352-355`), `subdir-ccflags-y` applies to "*the kbuild file where they are present and all subdirectories*" — meaning it already covers the current directory. So the `ccflags-y` line is technically redundant; `subdir-ccflags-y` alone would suffice. This is harmless (duplicate `-D` flags for files directly in `drivers/gpu/drm/` don't cause problems), and being explicit about both scopes is a reasonable style choice. Not worth blocking over.

**Commit message:** Clear and accurate. The Fixes tag correctly references the commit that introduced the original `CFLAGS-y` typo. The note about `depends on BROKEN` is helpful context.

**Reviewed-by worthy:** Yes — this is a correct, minimal fix.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-04-22 22:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 16:04 [PATCH] drm: Fix DYNAMIC_DEBUG_MODULE propagation to subdirectories Sean Paul
2026-04-22 22:49 ` Claude review: " Claude Code Review Bot
2026-04-22 22:49 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260420160425.3919114-1-sean@poorly.run \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox