From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: add warn_on_err macro
Date: Thu, 23 Apr 2026 08:52:54 +1000 [thread overview]
Message-ID: <review-patch1-20260421-nova-unload-v2-1-2fe54963af8b@nvidia.com> (raw)
In-Reply-To: <20260421-nova-unload-v2-1-2fe54963af8b@nvidia.com>
Patch Review
**File:** `rust/kernel/bug.rs`
```rust
+/// Report a warning if `res` is an error and return it unmodified.
+#[macro_export]
+macro_rules! warn_on_err {
+ ($res:expr) => {{
+ let res = $res;
+ let _ = $crate::warn_on!(res.is_err());
+ res
+ }};
+}
```
Clean and straightforward. Evaluates `$res` exactly once, delegates to the existing `warn_on!` macro, and returns the result unmodified. The `let _ =` discard of `warn_on!`'s return value is correct since we only care about the side effect (the WARN).
One minor point: this macro lives in `kernel/bug.rs` which is a shared crate-level utility. Since it's `#[macro_export]`, it becomes part of the `kernel` crate's public API. The Rust-for-Linux maintainers may want to weigh in on whether this is general enough to warrant that placement vs. being a driver-local helper. But given that `warn_on!` is already there, adding `warn_on_err!` alongside it is natural.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 22:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 6:16 [PATCH v2 0/5] gpu: nova-core: run unload sequence upon unbinding Alexandre Courbot
2026-04-21 6:16 ` [PATCH v2 1/5] rust: add warn_on_err macro Alexandre Courbot
2026-04-21 7:07 ` Eliot Courtney
2026-04-22 22:52 ` Claude Code Review Bot [this message]
2026-04-21 6:16 ` [PATCH v2 2/5] gpu: nova-core: use " Alexandre Courbot
2026-04-21 7:09 ` Eliot Courtney
2026-04-22 22:52 ` Claude review: " Claude Code Review Bot
2026-04-21 6:16 ` [PATCH v2 3/5] gpu: nova-core: do not import firmware commands into GSP command module Alexandre Courbot
2026-04-21 8:58 ` Eliot Courtney
2026-04-22 22:52 ` Claude review: " Claude Code Review Bot
2026-04-21 6:16 ` [PATCH v2 4/5] gpu: nova-core: send UNLOADING_GUEST_DRIVER GSP command upon unloading Alexandre Courbot
2026-04-21 9:42 ` Eliot Courtney
2026-04-21 14:27 ` Alexandre Courbot
2026-04-22 10:47 ` Alexandre Courbot
2026-04-22 22:52 ` Claude review: " Claude Code Review Bot
2026-04-21 6:16 ` [PATCH v2 5/5] gpu: nova-core: run Booter Unloader and FWSEC-SB upon unbinding Alexandre Courbot
2026-04-22 6:01 ` Eliot Courtney
2026-04-22 10:46 ` Alexandre Courbot
2026-04-22 22:52 ` Claude review: " Claude Code Review Bot
2026-04-22 22:52 ` Claude review: gpu: nova-core: run unload sequence " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-22 13:40 [PATCH v3 0/6] " Alexandre Courbot
2026-04-22 13:40 ` [PATCH v3 1/6] rust: add warn_on_err macro Alexandre Courbot
2026-04-22 21:34 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260421-nova-unload-v2-1-2fe54963af8b@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox