From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: run unload sequence upon unbinding
Date: Thu, 23 Apr 2026 08:52:54 +1000 [thread overview]
Message-ID: <review-overall-20260421-nova-unload-v2-0-2fe54963af8b@nvidia.com> (raw)
In-Reply-To: <20260421-nova-unload-v2-0-2fe54963af8b@nvidia.com>
Overall Series Review
Subject: gpu: nova-core: run unload sequence upon unbinding
Author: Alexandre Courbot <acourbot@nvidia.com>
Patches: 14
Reviewed: 2026-04-23T08:52:54.507537
---
This is a well-structured 5-patch series that implements proper GPU teardown upon driver unbind for the nova-core driver. The motivation is clear and important: without this, the GSP remains running after unbind (potentially accessing reclaimed memory), and the WPR2 region prevents re-probing without a full PCI reset — which itself can brick Blackwell GPUs due to a VBIOS bug.
The series is logically ordered: utility macro (1), refactor unbind to use it (2), namespace cleanup (3), GSP shutdown command (4), and full unload sequence (5). Each patch is reviewable in isolation and incrementally buildable. The code follows existing patterns in the codebase well (e.g., FWSEC/booter loading mirrors `boot()`, the command/reply pattern matches existing GSP commands).
Overall this looks good for merging. I have minor observations but no blocking issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 22:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 6:16 [PATCH v2 0/5] gpu: nova-core: run unload sequence upon unbinding Alexandre Courbot
2026-04-21 6:16 ` [PATCH v2 1/5] rust: add warn_on_err macro Alexandre Courbot
2026-04-21 7:07 ` Eliot Courtney
2026-04-22 22:52 ` Claude review: " Claude Code Review Bot
2026-04-21 6:16 ` [PATCH v2 2/5] gpu: nova-core: use " Alexandre Courbot
2026-04-21 7:09 ` Eliot Courtney
2026-04-22 22:52 ` Claude review: " Claude Code Review Bot
2026-04-21 6:16 ` [PATCH v2 3/5] gpu: nova-core: do not import firmware commands into GSP command module Alexandre Courbot
2026-04-21 8:58 ` Eliot Courtney
2026-04-22 22:52 ` Claude review: " Claude Code Review Bot
2026-04-21 6:16 ` [PATCH v2 4/5] gpu: nova-core: send UNLOADING_GUEST_DRIVER GSP command upon unloading Alexandre Courbot
2026-04-21 9:42 ` Eliot Courtney
2026-04-21 14:27 ` Alexandre Courbot
2026-04-22 10:47 ` Alexandre Courbot
2026-04-22 22:52 ` Claude review: " Claude Code Review Bot
2026-04-21 6:16 ` [PATCH v2 5/5] gpu: nova-core: run Booter Unloader and FWSEC-SB upon unbinding Alexandre Courbot
2026-04-22 6:01 ` Eliot Courtney
2026-04-22 10:46 ` Alexandre Courbot
2026-04-22 22:52 ` Claude review: " Claude Code Review Bot
2026-04-22 22:52 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-22 13:40 [PATCH v3 0/6] gpu: nova-core: run unload sequence " Alexandre Courbot
2026-04-22 21:34 ` Claude review: " Claude Code Review Bot
2026-04-27 6:56 [PATCH v4 0/8] " Alexandre Courbot
2026-04-28 5:01 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260421-nova-unload-v2-0-2fe54963af8b@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox