From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: run unload sequence upon unbinding
Date: Thu, 23 Apr 2026 07:34:42 +1000 [thread overview]
Message-ID: <review-overall-20260422-nova-unload-v3-0-1d2c81bd3ced@nvidia.com> (raw)
In-Reply-To: <20260422-nova-unload-v3-0-1d2c81bd3ced@nvidia.com>
Overall Series Review
Subject: gpu: nova-core: run unload sequence upon unbinding
Author: Alexandre Courbot <acourbot@nvidia.com>
Patches: 7
Reviewed: 2026-04-23T07:34:42.172558
---
This is a well-structured 6-patch series that implements the GSP firmware unload sequence for the nova-core GPU driver. The series addresses a real and important problem: without proper unload, the WPR2 region persists across driver unbind/rebind cycles, requiring a PCI reset (which itself can brick Blackwell GPUs due to a VBIOS bug). The patches are logically ordered — utility macro first, cleanup/refactoring in the middle, then the actual unload functionality. The code closely mirrors the boot path in reverse, which is the correct approach.
The series is in good shape overall. The concerns below are mostly minor.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 21:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 13:40 [PATCH v3 0/6] gpu: nova-core: run unload sequence upon unbinding Alexandre Courbot
2026-04-22 13:40 ` [PATCH v3 1/6] rust: add warn_on_err macro Alexandre Courbot
2026-04-22 21:34 ` Claude review: " Claude Code Review Bot
2026-04-22 13:40 ` [PATCH v3 2/6] gpu: nova-core: use " Alexandre Courbot
2026-04-22 21:34 ` Claude review: " Claude Code Review Bot
2026-04-22 13:40 ` [PATCH v3 3/6] gpu: nova-core: remove unneeded get_gsp_info proxy function Alexandre Courbot
2026-04-22 21:34 ` Claude review: " Claude Code Review Bot
2026-04-22 13:40 ` [PATCH v3 4/6] gpu: nova-core: do not import firmware commands into GSP command module Alexandre Courbot
2026-04-22 21:34 ` Claude review: " Claude Code Review Bot
2026-04-22 13:40 ` [PATCH v3 5/6] gpu: nova-core: send UNLOADING_GUEST_DRIVER GSP command upon unloading Alexandre Courbot
2026-04-22 21:34 ` Claude review: " Claude Code Review Bot
2026-04-22 13:40 ` [PATCH v3 6/6] gpu: nova-core: run Booter Unloader and FWSEC-SB upon unbinding Alexandre Courbot
2026-04-22 21:34 ` Claude review: " Claude Code Review Bot
2026-04-22 21:34 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-27 6:56 [PATCH v4 0/8] gpu: nova-core: run unload sequence " Alexandre Courbot
2026-04-28 5:01 ` Claude review: " Claude Code Review Bot
2026-04-21 6:16 [PATCH v2 0/5] " Alexandre Courbot
2026-04-22 22:52 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260422-nova-unload-v3-0-1d2c81bd3ced@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox