From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: use warn_on_err macro
Date: Thu, 23 Apr 2026 07:34:42 +1000 [thread overview]
Message-ID: <review-patch2-20260422-nova-unload-v3-2-1d2c81bd3ced@nvidia.com> (raw)
In-Reply-To: <20260422-nova-unload-v3-2-1d2c81bd3ced@nvidia.com>
Patch Review
**Status: Looks good**
Clean refactor of the `unbind` method:
```rust
- kernel::warn_on!(self
- .bar
- .access(dev)
- .inspect(|bar| self.sysmem_flush.unregister(bar))
- .is_err());
+ let Ok(bar) = kernel::warn_on_err!(self.bar.access(dev)) else {
+ return;
+ };
+
+ self.sysmem_flush.unregister(bar);
```
This is a meaningful improvement. The old code used `inspect` to perform a side-effect (unregister) inside a chain, which is harder to read and doesn't allow adding more steps between `bar.access()` and the end of the function. The new early-return pattern is idiomatic Rust and prepares for the additional unload logic added in patches 5 and 6.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 21:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 13:40 [PATCH v3 0/6] gpu: nova-core: run unload sequence upon unbinding Alexandre Courbot
2026-04-22 13:40 ` [PATCH v3 1/6] rust: add warn_on_err macro Alexandre Courbot
2026-04-22 21:34 ` Claude review: " Claude Code Review Bot
2026-04-22 13:40 ` [PATCH v3 2/6] gpu: nova-core: use " Alexandre Courbot
2026-04-22 21:34 ` Claude Code Review Bot [this message]
2026-04-22 13:40 ` [PATCH v3 3/6] gpu: nova-core: remove unneeded get_gsp_info proxy function Alexandre Courbot
2026-04-22 21:34 ` Claude review: " Claude Code Review Bot
2026-04-22 13:40 ` [PATCH v3 4/6] gpu: nova-core: do not import firmware commands into GSP command module Alexandre Courbot
2026-04-22 21:34 ` Claude review: " Claude Code Review Bot
2026-04-22 13:40 ` [PATCH v3 5/6] gpu: nova-core: send UNLOADING_GUEST_DRIVER GSP command upon unloading Alexandre Courbot
2026-04-22 21:34 ` Claude review: " Claude Code Review Bot
2026-04-22 13:40 ` [PATCH v3 6/6] gpu: nova-core: run Booter Unloader and FWSEC-SB upon unbinding Alexandre Courbot
2026-04-22 21:34 ` Claude review: " Claude Code Review Bot
2026-04-22 21:34 ` Claude review: gpu: nova-core: run unload sequence " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-21 6:16 [PATCH v2 0/5] " Alexandre Courbot
2026-04-21 6:16 ` [PATCH v2 2/5] gpu: nova-core: use warn_on_err macro Alexandre Courbot
2026-04-22 22:52 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260422-nova-unload-v3-2-1d2c81bd3ced@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox