From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/connector: Fix epoch_counter docs to reflect reality
Date: Thu, 23 Apr 2026 07:22:52 +1000 [thread overview]
Message-ID: <review-patch1-20260422-hot-plug-passup-v9-1-aef804255986@collabora.com> (raw)
In-Reply-To: <20260422-hot-plug-passup-v9-1-aef804255986@collabora.com>
Patch Review
**Verdict: Looks good.**
This is a straightforward documentation fix. The old comment:
```c
/** @epoch_counter: used to detect any other changes in connector, besides status */
```
is replaced with:
```c
/**
* @epoch_counter: Used to detect changes in connector. Increased when
* the connector, including its status, is changed.
*/
```
The fix is correct. The `epoch_counter` is bumped in `drm_connector_set_status_locked()` (among other places), so it very much does track status changes. The Fixes tag referencing the original commit `5186421cbfe2` is appropriate since the doc was wrong from the start.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 18:24 [PATCH v9 0/2] Pass down hot-plug CONNECTOR ID to user-space Nicolas Frattaroli
2026-04-22 18:24 ` [PATCH v9 1/2] drm/connector: Fix epoch_counter docs to reflect reality Nicolas Frattaroli
2026-04-22 21:22 ` Claude Code Review Bot [this message]
2026-04-22 18:24 ` [PATCH v9 2/2] drm: Send per-connector hotplug events Nicolas Frattaroli
2026-04-22 21:22 ` Claude review: " Claude Code Review Bot
2026-04-22 21:22 ` Claude review: Pass down hot-plug CONNECTOR ID to user-space Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-22 12:35 [PATCH v8 0/2] " Nicolas Frattaroli
2026-04-22 12:35 ` [PATCH v8 1/2] drm/connector: Fix epoch_counter docs to reflect reality Nicolas Frattaroli
2026-04-22 21:36 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260422-hot-plug-passup-v9-1-aef804255986@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox