public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Pass down hot-plug CONNECTOR ID to user-space
Date: Thu, 23 Apr 2026 07:22:52 +1000	[thread overview]
Message-ID: <review-overall-20260422-hot-plug-passup-v9-0-aef804255986@collabora.com> (raw)
In-Reply-To: <20260422-hot-plug-passup-v9-0-aef804255986@collabora.com>

Overall Series Review

Subject: Pass down hot-plug CONNECTOR ID to user-space
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Patches: 3
Reviewed: 2026-04-23T07:22:52.089066

---

This is a well-motivated 2-patch series at v9 that improves DRM hotplug event reporting by sending per-connector `CONNECTOR=<id>` uevents instead of generic global hotplug events. The cover letter clearly explains the real-world problem: compositors like Weston can miss rapid on-off-on HPD transitions because they can't identify which connector changed. The approach is sound — split the sysfs uevent (which is safe to call with the mutex held) from `drm_client_dev_hotplug()` (which needs to be called without mode_config locks), thus avoiding the deadlock that plagued earlier versions.

The series is clean and simple at 2 patches / net -1 lines changed. The first patch is a trivial doc fix, and the second implements the actual behavioral change. The code is a simplification over the current baseline which already had partial per-connector support (the `first_changed_connector` logic in `drm_helper_hpd_irq_event`). I have a few observations but nothing blocking.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-22 21:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 18:24 [PATCH v9 0/2] Pass down hot-plug CONNECTOR ID to user-space Nicolas Frattaroli
2026-04-22 18:24 ` [PATCH v9 1/2] drm/connector: Fix epoch_counter docs to reflect reality Nicolas Frattaroli
2026-04-22 21:22   ` Claude review: " Claude Code Review Bot
2026-04-22 18:24 ` [PATCH v9 2/2] drm: Send per-connector hotplug events Nicolas Frattaroli
2026-04-22 21:22   ` Claude review: " Claude Code Review Bot
2026-04-22 21:22 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-22 12:35 [PATCH v8 0/2] Pass down hot-plug CONNECTOR ID to user-space Nicolas Frattaroli
2026-04-22 21:36 ` Claude review: " Claude Code Review Bot
2026-02-17 19:00 [PATCH v7 0/2] " Nicolas Frattaroli
2026-02-17 20:43 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260422-hot-plug-passup-v9-0-aef804255986@collabora.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox