From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Pass down hot-plug CONNECTOR ID to user-space
Date: Thu, 23 Apr 2026 07:36:45 +1000 [thread overview]
Message-ID: <review-overall-20260422-hot-plug-passup-v8-0-5cfae6ba4119@collabora.com> (raw)
In-Reply-To: <20260422-hot-plug-passup-v8-0-5cfae6ba4119@collabora.com>
Overall Series Review
Subject: Pass down hot-plug CONNECTOR ID to user-space
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Patches: 4
Reviewed: 2026-04-23T07:36:45.659725
---
This is a well-motivated v8 of a 2-patch series that fixes a real-world problem: userspace (Weston) missing rapid HPD on-off-on transitions because the hotplug uevent didn't identify which connector changed. The approach — collecting changed connectors into an array, then sending per-connector hotplug events outside the lock — is sound and addresses the deadlock concern from earlier versions.
The series is clean, small, and the cover letter does a good job explaining the history and trade-offs. Two concerns worth discussing: (1) a potential array bounds issue and (2) a behavioral change in `drm_helper_hpd_irq_event` return value semantics.
**Verdict**: Mostly good, one potential bug to address, otherwise minor observations.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 21:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:35 [PATCH v8 0/2] Pass down hot-plug CONNECTOR ID to user-space Nicolas Frattaroli
2026-04-22 12:35 ` [PATCH v8 1/2] drm/connector: Fix epoch_counter docs to reflect reality Nicolas Frattaroli
2026-04-22 21:36 ` Claude review: " Claude Code Review Bot
2026-04-22 12:35 ` [PATCH v8 2/2] drm: Send per-connector hotplug events Nicolas Frattaroli
2026-04-22 14:30 ` Ville Syrjälä
2026-04-22 21:36 ` Claude review: " Claude Code Review Bot
2026-04-22 21:36 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-22 18:24 [PATCH v9 0/2] Pass down hot-plug CONNECTOR ID to user-space Nicolas Frattaroli
2026-04-22 21:22 ` Claude review: " Claude Code Review Bot
2026-02-17 19:00 [PATCH v7 0/2] " Nicolas Frattaroli
2026-02-17 20:43 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260422-hot-plug-passup-v8-0-5cfae6ba4119@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox