Claude review: drm/imagination: Fix segfault when updating ftrace mask

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Verdict: Good to merge.**

The fix is correct and minimal. Looking at the current source (`pvr_fw_trace.c`), the debugfs get/set functions both expect `struct pvr_device *`:

```c
static int pvr_fw_trace_mask_get(void *data, u64 *value)
{
	struct pvr_device *pvr_dev = data;
	*value = pvr_dev->fw_dev.fw_trace.group_mask;
	return 0;
}

static int pvr_fw_trace_mask_set(void *data, u64 value)
{
	struct pvr_device *pvr_dev = data;
	...
}
```

But the buggy code passed `fw_trace` (a `struct pvr_fw_trace *`):

```c
-	debugfs_create_file("trace_mask", 0600, dir, fw_trace,
+	debugfs_create_file("trace_mask", 0600, dir, pvr_dev,
 			    &pvr_fw_trace_mask_fops);
```

When `pvr_fw_trace_mask_set` then dereferences `pvr_dev->fw_dev.fw_trace.group_mask` using the mistyped pointer, it reads/writes garbage memory, causing the NULL pointer dereference shown in the crash log. The fix correctly passes `pvr_dev` which is already available as the function parameter.

The `Fixes:` tag (`a331631496a0 "drm/imagination: Simplify module parameters"`) is appropriate — that commit presumably changed the private data from `pvr_dev` to `fw_trace` as part of a refactor, introducing the regression.

The crash trace in the commit message is helpful for backporting and triage. No concerns.

---
Generated by Claude Code Patch Reviewer