Claude review: drm/imagination: FW trace bug fix and configuration update

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/imagination: FW trace bug fix and configuration update
Author: Brajesh Gupta <brajesh.gupta@imgtec.com>
Patches: 6
Reviewed: 2026-04-28T15:07:03.099203

---

This is a clean, well-motivated 2-patch series fixing a real NULL pointer dereference in the PowerVR imagination driver's firmware trace debugfs interface, and a follow-up to restrict the module parameter to read-only.

**Patch 1** fixes a genuine crash: the `debugfs_create_file("trace_mask", ...)` call passed `fw_trace` (a `struct pvr_fw_trace *`) as private data, but the debugfs get/set callbacks (`pvr_fw_trace_mask_get`/`pvr_fw_trace_mask_set`) cast the data pointer to `struct pvr_device *`. This type mismatch causes a NULL pointer dereference when writing to the debugfs file, exactly as shown in the crash trace.

**Patch 2** is a sensible hardening: since `init_fw_trace_mask` is only consumed at device init time and the debugfs `trace_mask` file (now fixed) is the proper runtime interface, making the sysfs parameter read-only prevents misleading writes that would have no effect on the running firmware.

Both patches are correct and ready to merge. No issues found.

---

---
Generated by Claude Code Patch Reviewer