public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: dp: fix kernel-doc warnings in dp.h
Date: Tue, 28 Apr 2026 14:01:51 +1000	[thread overview]
Message-ID: <review-patch1-20260427184442.693768-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260427184442.693768-1-rdunlap@infradead.org>

Patch Review

**Status: Clean**

The patch fixes four distinct kernel-doc issues:

1. **Missing `@` prefix on `tps3_supported`** (line 103 of the diff):
   ```c
   - * tps3_supported:
   + * @tps3_supported:
   ```
   Correct — kernel-doc requires `@` prefix for struct member documentation.

2. **Empty descriptions for `@apply_training` and `@configure`** (lines 113, 119 of the diff):
   ```c
   - * @apply_training:
   + * @apply_training: apply the link training
   ```
   ```c
   - * @configure:
   + * @configure: configure the DP link
   ```
   Correct — kernel-doc warns when `@member:` entries in a struct/ops doc block have no description text. The added descriptions are brief and appropriate.

3. **Misplaced nested struct member docs for `aux_rd_interval`** (lines 126–141 of the diff):
   The old code had `@cr` and `@ce` documented in a separate `/** */` block directly above the anonymous struct, which kernel-doc doesn't associate with the parent struct's doc block. The fix removes that orphaned comment and instead documents `aux_rd_interval.cr` and `aux_rd_interval.ce` as nested member entries in the parent `struct drm_dp_link` doc block:
   ```c
   + * @aux_rd_interval.cr: clock recovery read interval
   + * @aux_rd_interval.ce: channel equalization read interval
   ```
   This is the correct kernel-doc syntax for anonymous nested struct members, and eliminates both the "Excess struct member 'cr'" warning and the implicit missing-member warnings.

All four fixes are correct kernel-doc usage. The patch is well-scoped — it changes only documentation, no functional code. The commit message clearly lists all four warnings being fixed. The Acked-by from Mikko Perttunen is appropriate as the Tegra driver maintainer.

No concerns with this patch.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-28  4:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 18:44 [PATCH v2] drm/tegra: dp: fix kernel-doc warnings in dp.h Randy Dunlap
2026-04-28  4:01 ` Claude Code Review Bot [this message]
2026-04-28  4:01 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-02-19 21:55 [PATCH RESEND] " Randy Dunlap
2026-02-22 20:19 ` Claude review: " Claude Code Review Bot
2026-02-22 20:19 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260427184442.693768-1-rdunlap@infradead.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox