From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: tegra_drm.h: fix all uapi kernel-doc warnings
Date: Tue, 28 Apr 2026 14:00:47 +1000 [thread overview]
Message-ID: <review-patch1-20260427184454.693794-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260427184454.693794-1-rdunlap@infradead.org>
Patch Review
**Struct member descriptions (lines 307, 325 in patched file):**
The two added descriptions fix the documented warnings for `cmdbuf` and `target` members of `struct drm_tegra_reloc`:
```c
/** @cmdbuf: cmd information */
struct {
```
```c
/** @target: relocate target information */
struct {
```
These are correct and silence the warnings. Minor nit: `"cmd information"` is quite vague — something like `"command buffer location"` would better match the sub-fields (`handle` and `offset` into the command buffer), but this is a stylistic preference and the existing text is adequate.
**Define constant comments (lines 782–861 in patched file):**
The four `#define` comments are converted from bare `/**` blocks (which the kernel-doc parser flags as malformed) to proper `define MACRO - description` form. For example:
```c
/**
* define DRM_TEGRA_SUBMIT_CMD_GATHER_UPTR - \
* Execute Host1x opcodes from user pointer.
*
* Execute `words` words of Host1x opcodes specified in the `gather_data_ptr`
* buffer. Each GATHER_UPTR command uses successive words from the buffer.
*/
#define DRM_TEGRA_SUBMIT_CMD_GATHER_UPTR 0
```
The `\` line-continuation on the first `define` line is used to keep line length manageable, particularly for `DRM_TEGRA_SUBMIT_RELOC_SECTOR_LAYOUT`. This works with the kernel-doc script's line-joining logic, so it should parse correctly. The added short descriptions (`"Select sector layout swizzling..."`, `"Execute Host1x opcodes..."`, `"Wait for syncpoint (absolute)."`, `"Wait for syncpoint (relative)."`) are clear and appropriate.
**No functional code changes.** Only documentation comments are modified. No risk of runtime behavior change since this is a UAPI header and only comment lines are touched.
**Verdict:** Patch is correct and ready to merge. The warnings are real, the fixes are appropriate, and the Tegra maintainer has already acked it.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-28 4:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 18:44 [PATCH v3] drm/tegra: tegra_drm.h: fix all uapi kernel-doc warnings Randy Dunlap
2026-04-28 4:00 ` Claude Code Review Bot [this message]
2026-04-28 4:00 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-04 1:41 [PATCH v2] " Randy Dunlap
2026-03-05 3:56 ` Claude review: " Claude Code Review Bot
2026-03-05 3:56 ` Claude Code Review Bot
2026-02-26 21:58 [PATCH] " Randy Dunlap
2026-02-27 1:38 ` Claude review: " Claude Code Review Bot
2026-02-27 1:38 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260427184454.693794-1-rdunlap@infradead.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox