From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: Remove duplicate include of dce/dmub_hw_lock_mgr.h
Date: Tue, 28 Apr 2026 13:39:57 +1000 [thread overview]
Message-ID: <review-patch1-20260428030238.1012922-1-nichen@iscas.ac.cn> (raw)
In-Reply-To: <20260428030238.1012922-1-nichen@iscas.ac.cn>
Patch Review
**Status: Correct**
The file `dcn42_hwseq.c` included `"dce/dmub_hw_lock_mgr.h"` twice:
- Line 29 (retained): `#include "dce/dmub_hw_lock_mgr.h"` — used by `dmub_hw_lock_mgr_does_context_require_lock()` and `dmub_hw_lock_mgr_inbox0_cmd()` calls later in the file.
- Line ~38 (removed by this patch): a second, redundant `#include "dce/dmub_hw_lock_mgr.h"`.
The patch removes only the second occurrence, keeping the first. The remaining include is necessary since the file references `dmub_hw_lock_mgr_does_context_require_lock` and `dmub_hw_lock_mgr_inbox0_cmd` (lines 1032, 1039, 1054).
No issues. This is a straightforward duplicate include removal.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-28 3:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 3:02 [PATCH] drm/amd/display: Remove duplicate include of dce/dmub_hw_lock_mgr.h Chen Ni
2026-04-28 3:39 ` Claude Code Review Bot [this message]
2026-04-28 3:39 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260428030238.1012922-1-nichen@iscas.ac.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox