public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: regulator: document the Renesas R63419 based dual-DSI video mode Display Panels
Date: Tue, 05 May 2026 10:27:00 +1000	[thread overview]
Message-ID: <review-patch1-20260430-topic-sm8650-ayaneo-pocket-s2-r63419-v2-1-91ac10453d0c@linaro.org> (raw)
In-Reply-To: <20260430-topic-sm8650-ayaneo-pocket-s2-r63419-v2-1-91ac10453d0c@linaro.org>

Patch Review

**Subject line error:** The subject says `dt-bindings: regulator:` but this is a display panel binding, not a regulator binding. It should be `dt-bindings: display: panel:` to match the file path and convention.

**Should reference `panel-common-dual.yaml`:** The binding currently does:
```yaml
allOf:
  - $ref: panel-common.yaml#
```
Since this is a dual-DSI panel with `ports` containing `port@0` and `port@1`, it should reference `panel-common-dual.yaml#` instead, as other dual-DSI panel bindings do (e.g., `himax,hx83121a.yaml`, `novatek,nt35950.yaml`). This provides proper schema validation for the dual-port structure.

**Supply descriptions missing:** The supplies (`vdd-supply`, `vddio-supply`, etc.) are declared as `true` without descriptions. Other bindings (e.g., `himax,hx83121a.yaml`) add brief description strings explaining what each supply powers. Not strictly required but improves documentation quality.

**Minor:** The example has `vsn-supply` and `vsp-supply` listed in a different order than the property definitions (the properties list `vsp` before `vsn`, but the example swaps them). This is cosmetically inconsistent but functionally fine.

Otherwise the binding structure looks correct — compatibles, supplies, required properties, and the dual-port example all look reasonable.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-05  0:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 12:22 [PATCH v2 0/2] drm: panel: support the R63419 based dual-DSI video mode Display Panels Neil Armstrong
2026-04-30 12:22 ` [PATCH v2 1/2] dt-bindings: regulator: document the Renesas " Neil Armstrong
2026-05-03 12:34   ` Krzysztof Kozlowski
2026-05-04  7:00     ` Neil Armstrong
2026-05-05  0:27   ` Claude Code Review Bot [this message]
2026-04-30 12:22 ` [PATCH v2 2/2] drm: panel: add support for " Neil Armstrong
2026-05-05  0:27   ` Claude review: " Claude Code Review Bot
2026-05-05  0:27 ` Claude review: drm: panel: support the " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260430-topic-sm8650-ayaneo-pocket-s2-r63419-v2-1-91ac10453d0c@linaro.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox