Claude review: drm: panel: support the R63419 based dual-DSI video mode Display Panels

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm: panel: support the R63419 based dual-DSI video mode Display Panels
Author: Neil Armstrong <neil.armstrong@linaro.org>
Patches: 5
Reviewed: 2026-05-05T10:27:00.422343

---

This is a 2-patch series adding a new dual-DSI panel driver for the Renesas R63419 DDIC, used in Ayaneo handheld gaming devices. The series adds a DT binding (patch 1) and the panel driver (patch 2). The structure follows established dual-DSI panel driver patterns in the kernel (similar to `panel-sharp-lq079l1sx01.c` and `panel-himax-hx83121a.c`), and uses modern APIs like `devm_drm_panel_alloc` and `devm_regulator_bulk_get_const`.

However, there are several issues ranging from a critical MIPI DCS spec violation (incorrect command ordering) to cleanup path bugs and binding concerns.

**Key issues:**
1. **MIPI DCS command ordering is reversed** — `SET_DISPLAY_ON` is sent before `EXIT_SLEEP_MODE`, violating the MIPI DCS spec.
2. **Second DSI context errors are silently dropped** in both enable and disable paths.
3. **Should use `devm_mipi_dsi_attach()`** — the manual `mipi_dsi_attach()` has an incomplete cleanup path.
4. **DT binding subject line says "regulator"** instead of "display".
5. **DT binding should reference `panel-common-dual.yaml#`** for proper dual-DSI port schema validation.

---

---
Generated by Claude Code Patch Reviewer