Claude review: drm: panel: support the R63419 based dual-DSI video mode Display Panels

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm: panel: support the R63419 based dual-DSI video mode Display Panels
Author: Neil Armstrong <neil.armstrong@linaro.org>
Patches: 3
Reviewed: 2026-05-05T08:29:49.895264

---

This is a 2-patch series by Neil Armstrong (with driver code from KancyJoe) adding support for Renesas R63419-based dual-DSI video mode panels found in Ayaneo handheld gaming devices. The series consists of a DT binding (patch 1) and a panel driver (patch 2).

The overall structure is clean and follows modern panel driver conventions (uses `devm_drm_panel_alloc`, `mipi_dsi_multi_context`, `devm_regulator_bulk_get_const`, etc.). However, there are a few issues worth addressing:

**Key issues:**
1. The DSI init sequence sends display-on *before* exit-sleep-mode, which is reversed from the standard MIPI DCS order and from what other panel drivers do.
2. The dual-DSI error handling uses two separate `mipi_dsi_multi_context` structs but only checks `accum_err` from the first one — errors on the second DSI link are silently lost. The existing `mipi_dsi_dual()` macro solves this correctly.
3. The panel descriptors should be `const`.
4. The DT binding example has vsp/vsn supply names that appear swapped.

---

---
Generated by Claude Code Patch Reviewer