public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: tdo-tl070wsh30: Use devm_drm_panel_add()
Date: Tue, 05 May 2026 10:22:00 +1000	[thread overview]
Message-ID: <review-patch1-20260430141746.4214-1-pakmyeonghun@bagmyeonghun-ui-MacBookPro.local> (raw)
In-Reply-To: <20260430141746.4214-1-pakmyeonghun@bagmyeonghun-ui-MacBookPro.local>

Patch Review

**Build failure — function does not exist**

The core change:
```c
-	drm_panel_add(&tdo_tl070wsh30->base);
-
-	return 0;
+	return devm_drm_panel_add(dev, &tdo_tl070wsh30->base);
```

`devm_drm_panel_add()` is not declared in `include/drm/drm_panel.h` and is not defined anywhere in `drivers/gpu/drm/drm_panel.c` or elsewhere. This will fail at compile time with an implicit function declaration error. The existing API provides:
- `drm_panel_add(struct drm_panel *)` — void, non-managed
- `drm_panel_remove(struct drm_panel *)` — the matching cleanup
- `__devm_drm_panel_alloc()` — managed *allocation*, not registration

The correct approach to achieve managed panel registration would be one of:
1. Use `devm_add_action_or_reset()` to register a callback that calls `drm_panel_remove()` on cleanup, creating an ad-hoc devm wrapper.
2. Propose a new `devm_drm_panel_add()` helper in drm_panel.c/drm_panel.h as a preparatory patch, then use it here.

**Remove-side cleanup is correct but moot**

The removal of `drm_panel_remove()` from `tdo_tl070wsh30_panel_remove()` and the now-unused local variable is the right cleanup *if* the devm registration existed, but without it this just creates a leak where the panel is never unregistered.

**Fixes tag correctness**: The identified bug (panel remains registered if `mipi_dsi_attach()` fails) is real and the Fixes tag `cf40c6600592` appears correct, but the fix itself is broken.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-05  0:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 14:17 [PATCH v2] drm/panel: tdo-tl070wsh30: Use devm_drm_panel_add() 박명훈
2026-05-05  0:22 ` Claude Code Review Bot [this message]
2026-05-05  0:22 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260430141746.4214-1-pakmyeonghun@bagmyeonghun-ui-MacBookPro.local \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox