From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: tdo-tl070wsh30: Use devm_drm_panel_add()
Date: Tue, 05 May 2026 10:22:00 +1000 [thread overview]
Message-ID: <review-overall-20260430141746.4214-1-pakmyeonghun@bagmyeonghun-ui-MacBookPro.local> (raw)
In-Reply-To: <20260430141746.4214-1-pakmyeonghun@bagmyeonghun-ui-MacBookPro.local>
Overall Series Review
Subject: drm/panel: tdo-tl070wsh30: Use devm_drm_panel_add()
Author: "=?UTF-8?q?=EB=B0=95=EB=AA=85=ED=9B=88?=" <mhun512@gmail.com>
Patches: 1
Reviewed: 2026-05-05T10:22:00.617103
---
**NAK — this patch will not compile.** The patch replaces `drm_panel_add()` with `devm_drm_panel_add()`, but `devm_drm_panel_add()` does not exist in the kernel. There is no declaration in `include/drm/drm_panel.h` and no definition in `drivers/gpu/drm/drm_panel.c`. The only devm panel functions that exist are `__devm_drm_panel_alloc()` and `devm_drm_panel_add_follower()`, neither of which is a managed wrapper around `drm_panel_add()`.
The stated goal — making panel registration managed so it's automatically unwound on probe failure — is a valid improvement. However, the approach is incorrect because the required API does not exist.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-05 0:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 14:17 [PATCH v2] drm/panel: tdo-tl070wsh30: Use devm_drm_panel_add() 박명훈
2026-05-05 0:22 ` Claude review: " Claude Code Review Bot
2026-05-05 0:22 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260430141746.4214-1-pakmyeonghun@bagmyeonghun-ui-MacBookPro.local \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox