public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: panel: Add Novatek NT37705
Date: Tue, 05 May 2026 09:22:46 +1000	[thread overview]
Message-ID: <review-patch1-20260501-fp6-panel-v1-1-e09cb05651cc@fairphone.com> (raw)
In-Reply-To: <20260501-fp6-panel-v1-1-e09cb05651cc@fairphone.com>

Patch Review

The binding is clean and follows existing patterns. One concern:

**Compatible property uses `contains` instead of `const` or `items`:**
```yaml
  compatible:
    contains:
      const: boe,bj631jhm-t71-d900
```

Using `contains` means the compatible property is valid as long as `boe,bj631jhm-t71-d900` appears *anywhere* in the list, with any number of other strings. For a binding with a single known panel, the conventional pattern is either:
```yaml
  compatible:
    const: boe,bj631jhm-t71-d900
```
or, if you intend to support future panels sharing the NT37705 IC as fallback compatibles:
```yaml
  compatible:
    items:
      - enum:
          - boe,bj631jhm-t71-d900
      - const: novatek,nt37705
```

Compare with `novatek,nt37801.yaml` which uses `oneOf` with explicit `items` lists. The DT binding maintainers may flag this.

Otherwise the binding looks correct -- three supplies (vddio, dvdd, vci), reset-gpios, reg, and port are all required and match the driver.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-04 23:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01 13:52 [PATCH 0/4] Add Novatek NT37705 panel driver for Fairphone (Gen. 6) Luca Weiss
2026-05-01 13:52 ` [PATCH 1/4] dt-bindings: display: panel: Add Novatek NT37705 Luca Weiss
2026-05-01 15:51   ` Conor Dooley
2026-05-04 13:36     ` Luca Weiss
2026-05-04 20:45       ` Krzysztof Kozlowski
2026-05-04 20:47         ` Krzysztof Kozlowski
2026-05-04 23:22   ` Claude Code Review Bot [this message]
2026-05-01 13:52 ` [PATCH 2/4] drm/panel: Add driver for Novatek NT37705 panel Luca Weiss
2026-05-01 18:17   ` David Heidelberg
2026-05-04 23:22   ` Claude review: " Claude Code Review Bot
2026-05-01 13:52 ` [PATCH 3/4] arm64: defconfig: Enable " Luca Weiss
2026-05-04 22:41   ` Dmitry Baryshkov
2026-05-04 23:22   ` Claude review: " Claude Code Review Bot
2026-05-01 13:52 ` [PATCH 4/4] arm64: dts: qcom: milos-fairphone-fp6: Enable display Luca Weiss
2026-05-04 22:40   ` Dmitry Baryshkov
2026-05-04 23:22   ` Claude review: " Claude Code Review Bot
2026-05-04 23:22 ` Claude review: Add Novatek NT37705 panel driver for Fairphone (Gen. 6) Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260501-fp6-panel-v1-1-e09cb05651cc@fairphone.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox