From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: verisilicon: add max cursor size to HWDB
Date: Thu, 07 May 2026 13:14:48 +1000 [thread overview]
Message-ID: <review-patch1-20260506175610.2542888-2-zhengxingda@iscas.ac.cn> (raw)
In-Reply-To: <20260506175610.2542888-2-zhengxingda@iscas.ac.cn>
Patch Review
This patch is clean and already has Thomas Zimmermann's Reviewed-by.
- The comment explaining the square-only constraint is good.
- Using `int32_t` for `max_cursor_size` matches how the cursor plane code uses it. Though `u32` would arguably be more natural for a size value, it's not wrong.
- All 4 HWDB entries are updated to `max_cursor_size = 64`. The cover letter says DC8200 variants support 32 and 64 while some DC8000 support up to 256, so 64 is a safe common value.
No issues with this patch.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-07 3:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 17:56 [PATCH v3 0/2] drm: verisilicon: add hardware cursor support Icenowy Zheng
2026-05-06 17:56 ` [PATCH v3 1/2] drm: verisilicon: add max cursor size to HWDB Icenowy Zheng
2026-05-07 3:14 ` Claude Code Review Bot [this message]
2026-05-06 17:56 ` [PATCH v3 2/2] drm: verisilicon: add support for cursor planes Icenowy Zheng
2026-05-07 3:14 ` Claude review: " Claude Code Review Bot
2026-05-07 3:14 ` Claude review: drm: verisilicon: add hardware cursor support Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-24 6:02 [PATCH -next v2 0/2] " Icenowy Zheng
2026-03-24 6:02 ` [PATCH -next v2 1/2] drm: verisilicon: add max cursor size to HWDB Icenowy Zheng
2026-03-24 21:03 ` Claude review: " Claude Code Review Bot
2026-03-09 8:53 [PATCH -next 0/2] drm: verisilicon: add hardware cursor support Icenowy Zheng
2026-03-09 8:53 ` [PATCH -next 1/2] drm: verisilicon: add max cursor size to HWDB Icenowy Zheng
2026-03-10 2:36 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260506175610.2542888-2-zhengxingda@iscas.ac.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox