From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: verisilicon: add hardware cursor support
Date: Thu, 07 May 2026 13:14:48 +1000 [thread overview]
Message-ID: <review-overall-20260506175610.2542888-1-zhengxingda@iscas.ac.cn> (raw)
In-Reply-To: <20260506175610.2542888-1-zhengxingda@iscas.ac.cn>
Overall Series Review
Subject: drm: verisilicon: add hardware cursor support
Author: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Patches: 3
Reviewed: 2026-05-07T13:14:48.302369
---
This is a well-structured 2-patch series adding hardware cursor support to the Verisilicon display controller driver. Patch 1 adds the HWDB plumbing, patch 2 implements the cursor plane. The approach is sound and the series shows good v3 iteration improvements (simpler validation, proper modifier list, visibility-based check skipping).
However, **patch 2 has a critical bug**: the negative-coordinate offset values are never shifted into their register field positions, so partially-offscreen cursors will not work correctly. There is also an off-by-one error in the coordinate range checks, minor typos in register defines, and a missing `cursor_width`/`cursor_height` setting in mode_config.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-07 3:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 17:56 [PATCH v3 0/2] drm: verisilicon: add hardware cursor support Icenowy Zheng
2026-05-06 17:56 ` [PATCH v3 1/2] drm: verisilicon: add max cursor size to HWDB Icenowy Zheng
2026-05-07 3:14 ` Claude review: " Claude Code Review Bot
2026-05-06 17:56 ` [PATCH v3 2/2] drm: verisilicon: add support for cursor planes Icenowy Zheng
2026-05-07 3:14 ` Claude review: " Claude Code Review Bot
2026-05-07 3:14 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-24 6:02 [PATCH -next v2 0/2] drm: verisilicon: add hardware cursor support Icenowy Zheng
2026-03-24 21:03 ` Claude review: " Claude Code Review Bot
2026-03-09 8:53 [PATCH -next 0/2] " Icenowy Zheng
2026-03-10 2:36 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260506175610.2542888-1-zhengxingda@iscas.ac.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox