public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: leds: backlight: add Silergy SY7758
Date: Sat, 16 May 2026 16:17:41 +1000	[thread overview]
Message-ID: <review-patch1-20260511-sy7758-v1-1-999a33081304@gmail.com> (raw)
In-Reply-To: <20260511-sy7758-v1-1-999a33081304@gmail.com>

Patch Review

The binding YAML and MAINTAINERS entry are clean and well-structured.

**Minor issue — example advertises properties the driver ignores:**

The DT example includes `max-brightness` and `default-brightness` (inherited from `common.yaml`):

```yaml
        backlight@36 {
            compatible = "silergy,sy7758";
            reg = <0x36>;
            max-brightness = <4080>;
            default-brightness = <1500>;
        };
```

These properties are defined in the common schema so they're valid from a binding perspective, but the driver (patch 2) hardcodes `MAX_BRIGHTNESS` and `DEFAULT_BRIGHTNESS` as `#define` constants and never reads them from DT. Either the driver should consume these properties, or the example should not include them (to avoid misleading DT authors into thinking they're functional).

**Nit:** The binding looks good otherwise — `allOf: - $ref: common.yaml#`, `unevaluatedProperties: false`, required properties, and the MAINTAINERS entry are all correct.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  6:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-10 17:08 [PATCH 0/2] backlight: add support for Silergy SY7758 Alexandre Hamamdjian via B4 Relay
2026-05-10 17:08 ` [PATCH 1/2] dt-bindings: leds: backlight: add " Alexandre Hamamdjian via B4 Relay
2026-05-15  7:37   ` Krzysztof Kozlowski
2026-05-16  6:17   ` Claude Code Review Bot [this message]
2026-05-10 17:08 ` [PATCH 2/2] backlight: sy7758: add Silergy SY7758 backlight driver Alexandre Hamamdjian via B4 Relay
2026-05-16  6:17   ` Claude review: " Claude Code Review Bot
2026-05-16  6:17 ` Claude review: backlight: add support for Silergy SY7758 Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260511-sy7758-v1-1-999a33081304@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox