From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
Date: Sat, 16 May 2026 15:39:27 +1000 [thread overview]
Message-ID: <review-patch1-20260511095914.1200201-1-wenst@chromium.org> (raw)
In-Reply-To: <20260511095914.1200201-1-wenst@chromium.org>
Patch Review
**Sorted order — correct.** The AUO entry `0xcb8f` is correctly placed between `0xc9a8` and `0xcdba`. The BOE entry `0x0a25` is correctly placed between `0x0a1b` and `0x0a36`.
**Delay profiles — appropriate.**
The AUO entry uses `&delay_200_500_e50`, which is the standard delay profile used by nearly all surrounding AUO entries. Reasonable default for a datasheet-only entry.
The BOE entry uses `&delay_200_500_e50_po2e200`, which adds a `.powered_on_to_enable = 200` field beyond the basic `delay_200_500_e50`. This delay struct is already used by several other BOE panels (e.g., `NV133FHM-N42` at `0x0717`, `NV116WHM-N45` at `0x0754`). The choice of a delay with `powered_on_to_enable` suggests the panel needs extra time after power-on before the display can be enabled, and since this was tested on actual hardware, this is a validated choice.
**Commit message** is properly formatted and includes an honest caveat that the AUO entry is datasheet-only. The Signed-off-by is present.
**No issues.** This is a minimal, well-ordered data-only patch. Already merged to drm-next.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 5:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 9:59 [PATCH] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0 Chen-Yu Tsai
2026-05-11 14:16 ` Doug Anderson
2026-05-16 5:39 ` Claude review: " Claude Code Review Bot
2026-05-16 5:39 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-12 4:54 [PATCH v2] " Chen-Yu Tsai
2026-05-16 4:19 ` Claude review: " Claude Code Review Bot
2026-05-16 4:19 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260511095914.1200201-1-wenst@chromium.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox