public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
Date: Sat, 16 May 2026 14:19:49 +1000	[thread overview]
Message-ID: <review-patch1-20260512045454.1505733-1-wenst@chromium.org> (raw)
In-Reply-To: <20260512045454.1505733-1-wenst@chromium.org>

Patch Review

**EDID verification:** Both product IDs are correctly extracted from the provided raw EDIDs. AUO bytes `8f cb` → 0xcb8f and BOE bytes `25 0a` → 0x0a25. Manufacturer IDs also decode correctly.

**Sort order:** Both entries are inserted in the correct ascending order by product ID:
- AUO: 0xc9a8 < **0xcb8f** < 0xcdba ✓
- BOE: 0x0a1b < **0x0a25** < 0x0a36 ✓

**Delay structures:**

```c
EDP_PANEL_ENTRY('A', 'U', 'O', 0xcb8f, &delay_200_500_e50, "B133HAN06.6"),
```
Uses `delay_200_500_e50` (hpd_absent=200, unprepare=500, enable=50) — a common default for AUO panels. Reasonable for a datasheet-only entry, consistent with neighboring AUO entries that use the same delay.

```c
EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a25, &delay_200_500_e50_po2e200, "NV133FHM-N4F V8.0"),
```
Uses `delay_200_500_e50_po2e200`, which adds `powered_on_to_enable=200` on top of the base delays. Since this was hardware-tested, the choice of a delay with `powered_on_to_enable` is presumably validated. The nearby BOE entry at 0x0a1b uses the simpler `delay_200_500_e50`, so the difference is intentional and worth noting — the `powered_on_to_enable` delay likely reflects an observed requirement on this specific panel/board combination.

**Minor observation (not blocking):** The AUO panel was not tested on hardware. The commit message is transparent about this ("solely based on the provided datasheet"). If the delay turns out to be wrong, it can be adjusted later — standard practice for this table.

**No issues found.** Reviewed-by would be appropriate.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  4:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12  4:54 [PATCH v2] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0 Chen-Yu Tsai
2026-05-12 16:19 ` Doug Anderson
2026-05-16  4:19 ` Claude Code Review Bot [this message]
2026-05-16  4:19 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-11  9:59 [PATCH] " Chen-Yu Tsai
2026-05-16  5:39 ` Claude review: " Claude Code Review Bot
2026-05-16  5:39 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260512045454.1505733-1-wenst@chromium.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox