public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
@ 2026-05-12  4:54 Chen-Yu Tsai
  2026-05-12 16:19 ` Doug Anderson
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2026-05-12  4:54 UTC (permalink / raw)
  To: Douglas Anderson, Neil Armstrong, Jessica Zhang,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann
  Cc: Chen-Yu Tsai, David Airlie, Simona Vetter, dri-devel,
	linux-kernel

These two panels are found in MT8195 Dojo, a.k.a. the HP Chromebook
x360 13b-ca0xxx laptop.

Only the BOE entry was tested on an actual device. The AUO entry is
solely based on the provided datasheet.

raw EDIDs:

AUO B133HAN06.6 (from the datasheet)

00 ff ff ff ff ff ff 00 06 af 8f cb 00 00 00 00
2f 1d 01 04 95 1d 11 78 03 93 05 92 58 59 90 29
1d 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
01 01 01 01 01 01 14 37 80 b8 70 38 24 40 10 10
3e 00 25 a5 10 00 00 18 b8 24 80 b8 70 38 24 40
10 10 3e 00 25 a5 10 00 00 18 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 02
00 10 48 ff 0f 3c 7d 14 0e 1d 7d 20 20 20 00 77

BOE NV133FHM-N4F V8.0 (from an actual panel)

00 ff ff ff ff ff ff 00 09 e5 25 0a 00 00 00 00
2c 1f 01 04 95 1d 11 78 03 28 65 97 59 54 8e 27
1e 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
01 01 01 01 01 01 a4 39 80 c8 70 38 50 40 30 20
36 00 26 a5 10 00 00 1a 6d 26 80 c8 70 38 50 40
30 20 36 00 26 a5 10 00 00 1a 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 02
00 0d 40 ff 0a 3c 7d 0f 0f 1f 7d 00 00 00 00 d2

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
Changes since v1:
- Added raw EDIDs to commit message
---
 drivers/gpu/drm/panel/panel-edp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index f3cdaea89b29..98301aec2f4a 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -1955,6 +1955,7 @@ static const struct edp_panel_entry edp_panels[] = {
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0xb7a9, &delay_200_500_e50, "B140HAK03.3"),
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0xc4b4, &delay_200_500_e50, "B116XAT04.1"),
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0xc9a8, &delay_200_500_e50, "B140QAN08.H"),
+	EDP_PANEL_ENTRY('A', 'U', 'O', 0xcb8f, &delay_200_500_e50, "B133HAN06.6"),
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0xcdba, &delay_200_500_e50, "B140UAX01.2"),
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0xd497, &delay_200_500_e50, "B120XAN01.0"),
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0xf390, &delay_200_500_e50, "B140XTN07.7"),
@@ -2003,6 +2004,7 @@ static const struct edp_panel_entry edp_panels[] = {
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x09ae, &delay_200_500_e200, "NT140FHM-N45"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x09dd, &delay_200_500_e50, "NT116WHM-N21"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a1b, &delay_200_500_e50, "NV133WUM-N63"),
+	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a25, &delay_200_500_e50_po2e200, "NV133FHM-N4F V8.0"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a36, &delay_200_500_e200, "Unknown"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a3e, &delay_200_500_e80_d50, "NV116WHM-N49"),
 	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a5d, &delay_200_500_e50, "NV116WHM-N45"),
-- 
2.54.0.563.g4f69b47b94-goog


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
  2026-05-12  4:54 [PATCH v2] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0 Chen-Yu Tsai
@ 2026-05-12 16:19 ` Doug Anderson
  2026-05-16  4:19 ` Claude review: " Claude Code Review Bot
  2026-05-16  4:19 ` Claude Code Review Bot
  2 siblings, 0 replies; 6+ messages in thread
From: Doug Anderson @ 2026-05-12 16:19 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
	linux-kernel

Hi,

On Mon, May 11, 2026 at 9:55 PM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> These two panels are found in MT8195 Dojo, a.k.a. the HP Chromebook
> x360 13b-ca0xxx laptop.
>
> Only the BOE entry was tested on an actual device. The AUO entry is
> solely based on the provided datasheet.
>
> raw EDIDs:
>
> AUO B133HAN06.6 (from the datasheet)
>
> 00 ff ff ff ff ff ff 00 06 af 8f cb 00 00 00 00
> 2f 1d 01 04 95 1d 11 78 03 93 05 92 58 59 90 29
> 1d 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 14 37 80 b8 70 38 24 40 10 10
> 3e 00 25 a5 10 00 00 18 b8 24 80 b8 70 38 24 40
> 10 10 3e 00 25 a5 10 00 00 18 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 02
> 00 10 48 ff 0f 3c 7d 14 0e 1d 7d 20 20 20 00 77
>
> BOE NV133FHM-N4F V8.0 (from an actual panel)
>
> 00 ff ff ff ff ff ff 00 09 e5 25 0a 00 00 00 00
> 2c 1f 01 04 95 1d 11 78 03 28 65 97 59 54 8e 27
> 1e 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 a4 39 80 c8 70 38 50 40 30 20
> 36 00 26 a5 10 00 00 1a 6d 26 80 c8 70 38 50 40
> 30 20 36 00 26 a5 10 00 00 1a 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 02
> 00 0d 40 ff 0a 3c 7d 0f 0f 1f 7d 00 00 00 00 d2
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> Changes since v1:
> - Added raw EDIDs to commit message
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 2 ++
>  1 file changed, 2 insertions(+)

I'd previously seen the AUO 0xcb8f panel as one missing and the EDID I
gathered matches your datasheet.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Pushed to drm-misc-next:

[1/1] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
      commit: 5dd1ff95c623b8118ccaae3242119b8552f7b98f

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Claude review: drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
  2026-05-12  4:54 [PATCH v2] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0 Chen-Yu Tsai
  2026-05-12 16:19 ` Doug Anderson
  2026-05-16  4:19 ` Claude review: " Claude Code Review Bot
@ 2026-05-16  4:19 ` Claude Code Review Bot
  2 siblings, 0 replies; 6+ messages in thread
From: Claude Code Review Bot @ 2026-05-16  4:19 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
Author: Chen-Yu Tsai <wenst@chromium.org>
Patches: 2
Reviewed: 2026-05-16T14:19:49.261565

---

This is a single, straightforward patch adding two new eDP panel entries for panels found in the HP Chromebook x360 13b-ca0xxx (MT8195 Dojo). The patch is well-formed: raw EDIDs are included in the commit message (added in v2), product IDs correctly decoded from those EDIDs, sort order is maintained in both the AUO and BOE table sections, and both referenced delay structures exist.

The BOE panel was tested on actual hardware; the AUO entry is based solely on the datasheet. Both panels are 13.3" FHD (1920x1080) eDP panels based on the EDID detailed timing descriptors.

**Verdict: Patch looks good.**

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Claude review: drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
  2026-05-12  4:54 [PATCH v2] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0 Chen-Yu Tsai
  2026-05-12 16:19 ` Doug Anderson
@ 2026-05-16  4:19 ` Claude Code Review Bot
  2026-05-16  4:19 ` Claude Code Review Bot
  2 siblings, 0 replies; 6+ messages in thread
From: Claude Code Review Bot @ 2026-05-16  4:19 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**EDID verification:** Both product IDs are correctly extracted from the provided raw EDIDs. AUO bytes `8f cb` → 0xcb8f and BOE bytes `25 0a` → 0x0a25. Manufacturer IDs also decode correctly.

**Sort order:** Both entries are inserted in the correct ascending order by product ID:
- AUO: 0xc9a8 < **0xcb8f** < 0xcdba ✓
- BOE: 0x0a1b < **0x0a25** < 0x0a36 ✓

**Delay structures:**

```c
EDP_PANEL_ENTRY('A', 'U', 'O', 0xcb8f, &delay_200_500_e50, "B133HAN06.6"),
```
Uses `delay_200_500_e50` (hpd_absent=200, unprepare=500, enable=50) — a common default for AUO panels. Reasonable for a datasheet-only entry, consistent with neighboring AUO entries that use the same delay.

```c
EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a25, &delay_200_500_e50_po2e200, "NV133FHM-N4F V8.0"),
```
Uses `delay_200_500_e50_po2e200`, which adds `powered_on_to_enable=200` on top of the base delays. Since this was hardware-tested, the choice of a delay with `powered_on_to_enable` is presumably validated. The nearby BOE entry at 0x0a1b uses the simpler `delay_200_500_e50`, so the difference is intentional and worth noting — the `powered_on_to_enable` delay likely reflects an observed requirement on this specific panel/board combination.

**Minor observation (not blocking):** The AUO panel was not tested on hardware. The commit message is transparent about this ("solely based on the provided datasheet"). If the delay turns out to be wrong, it can be adjusted later — standard practice for this table.

**No issues found.** Reviewed-by would be appropriate.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Claude review: drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
  2026-05-11  9:59 [PATCH] " Chen-Yu Tsai
  2026-05-16  5:39 ` Claude review: " Claude Code Review Bot
@ 2026-05-16  5:39 ` Claude Code Review Bot
  1 sibling, 0 replies; 6+ messages in thread
From: Claude Code Review Bot @ 2026-05-16  5:39 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
Author: Chen-Yu Tsai <wenst@chromium.org>
Patches: 2
Reviewed: 2026-05-16T15:39:27.225758

---

This is a single, straightforward patch adding two new eDP panel entries to `panel-edp.c` for the HP Chromebook x360 13b-ca0xxx (MT8195 Dojo). The patch is **already merged** into drm-next (both entries are present in the current tree), which explains why it could not be applied cleanly.

The patch is clean and correct:
- Both entries are inserted in the proper sorted order by product ID within their respective manufacturer blocks.
- The delay profiles chosen are appropriate and consistent with similar panels.
- The commit message is clear and honestly notes that only the BOE panel was tested on hardware.

No issues found.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Claude review: drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
  2026-05-11  9:59 [PATCH] " Chen-Yu Tsai
@ 2026-05-16  5:39 ` Claude Code Review Bot
  2026-05-16  5:39 ` Claude Code Review Bot
  1 sibling, 0 replies; 6+ messages in thread
From: Claude Code Review Bot @ 2026-05-16  5:39 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**Sorted order — correct.** The AUO entry `0xcb8f` is correctly placed between `0xc9a8` and `0xcdba`. The BOE entry `0x0a25` is correctly placed between `0x0a1b` and `0x0a36`.

**Delay profiles — appropriate.**

The AUO entry uses `&delay_200_500_e50`, which is the standard delay profile used by nearly all surrounding AUO entries. Reasonable default for a datasheet-only entry.

The BOE entry uses `&delay_200_500_e50_po2e200`, which adds a `.powered_on_to_enable = 200` field beyond the basic `delay_200_500_e50`. This delay struct is already used by several other BOE panels (e.g., `NV133FHM-N42` at `0x0717`, `NV116WHM-N45` at `0x0754`). The choice of a delay with `powered_on_to_enable` suggests the panel needs extra time after power-on before the display can be enabled, and since this was tested on actual hardware, this is a validated choice.

**Commit message** is properly formatted and includes an honest caveat that the AUO entry is datasheet-only. The Signed-off-by is present.

**No issues.** This is a minimal, well-ordered data-only patch. Already merged to drm-next.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-05-16  5:39 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-12  4:54 [PATCH v2] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0 Chen-Yu Tsai
2026-05-12 16:19 ` Doug Anderson
2026-05-16  4:19 ` Claude review: " Claude Code Review Bot
2026-05-16  4:19 ` Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-11  9:59 [PATCH] " Chen-Yu Tsai
2026-05-16  5:39 ` Claude review: " Claude Code Review Bot
2026-05-16  5:39 ` Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox